Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor preview should not show hidden elements #2934

Open
Discostu36 opened this issue Mar 11, 2020 · 3 comments
Open

Editor preview should not show hidden elements #2934

Discostu36 opened this issue Mar 11, 2020 · 3 comments

Comments

@Discostu36
Copy link

Discostu36 commented Mar 11, 2020

Description

When using the preview mode in backend, hidden content is shown.

Steps to Reproduce

  1. Create a page
  2. Add elements to the page
  3. Hide one of these elements
  4. Switch from editing mode to preview mode

Expected behavior

The page should be rendered exactly how it would look in frontend after publishing. Hidden elements should be hidden.

Actual behavior

Hidden elements are shown in the preview.

Affected Versions

Neos: 5.0.4

Flow: 6.0.5

@kdambekalns
Copy link
Member

Well, see #2711 for the change that made this possible (again). Obviously there are use cases for both ways, seeing and not seeing hidden stuff. 🤷‍♂️

@Discostu36
Copy link
Author

Just to make sure there is no misunderstanding:

  • I'm not talking about hidden pages, but about hidden content elements inside a page.
  • I'm talking about the preview options behind this dropdown

grafik

@mficzel
Copy link
Member

mficzel commented Jul 10, 2020

Ran into the "probably" same issue for the preview-link, i assume there is pretty much the same logic used. Hidden contents are shown in preview even on documents that are not hidden at all.

Not sure what exactly would be the expected/correct behavior. Ignore hidden only for the current documentNode but not for everything else would work for my case but there will probably be others. Also not sure this is easy to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants