Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safekeeper: efficient shard catchup for WAL cursor fan-out #9338

Open
Tracked by #9329
erikgrinaker opened this issue Oct 9, 2024 · 0 comments
Open
Tracked by #9329

safekeeper: efficient shard catchup for WAL cursor fan-out #9338

erikgrinaker opened this issue Oct 9, 2024 · 0 comments
Labels
a/scalability Area: related to scalability c/storage/safekeeper Component: storage: safekeeper

Comments

@erikgrinaker
Copy link
Contributor

erikgrinaker commented Oct 9, 2024

After #9337, when shards restart and need to catch up on old WAL, each shard will pull WAL records from S3 and filter them. This results in O(catchup_ranges) work. We should do this work once across multiple shards, since we expect many shards to require catchup at roughly the same time.

TODO: details post-RFC.

Consider gossiping timeline progress between safekeepers to know how many shards are offline/lagging.

Consider memory budgeting. Simple approach: estimate timeline catchup volume from LSNs, acquire from semaphore, block when unavailable. Consider QoS to prioritize "important" tenants.

@erikgrinaker erikgrinaker added c/storage/safekeeper Component: storage: safekeeper a/scalability Area: related to scalability labels Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/scalability Area: related to scalability c/storage/safekeeper Component: storage: safekeeper
Projects
None yet
Development

No branches or pull requests

1 participant