Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: wait until pageserver is ready in NeonPageserver.start #4864

Closed
LizardWizzard opened this issue Aug 1, 2023 · 1 comment
Closed

tests: wait until pageserver is ready in NeonPageserver.start #4864

LizardWizzard opened this issue Aug 1, 2023 · 1 comment
Labels
a/test/flaky Area: related to flaky tests a/test Area: related to testing c/storage/pageserver Component: storage: pageserver m/good_first_issue Moment: when doing your first Neon contributions

Comments

@LizardWizzard
Copy link
Contributor

Context: #4856 (comment)

TLDR: In tests we sometimes start some operations immediately after calling pageserver.start which leads to flakiness because sometimes pageserver startup sequence is not fully completed quick enough to be invisible for the test. Most often this is the case when real_s3 remote storage backend is used.

The expected solution is to add to pageserver http endpoint that waits for init_done_rx. See things around InitializationOrder.

Http endpoint can just block, or polling needs to be implemented on python side.

Initially discussed with @koivunej
@LizardWizzard LizardWizzard added c/storage/pageserver Component: storage: pageserver a/test Area: related to testing m/good_first_issue Moment: when doing your first Neon contributions a/test/flaky Area: related to flaky tests labels Aug 1, 2023
@rmodpur rmodpur mentioned this issue Oct 9, 2023
Closed
@koivunej koivunej mentioned this issue Oct 23, 2023
Closed
@koivunej
Copy link
Member

#5580 already implemented this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a/test/flaky Area: related to flaky tests a/test Area: related to testing c/storage/pageserver Component: storage: pageserver m/good_first_issue Moment: when doing your first Neon contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: wait tenants to be loaded on NeonPageserver.start rmodpur/neon
2 participants
@koivunej @LizardWizzard