Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing docs #229

Merged
merged 5 commits into from
Jun 10, 2019
Merged

Add missing docs #229

merged 5 commits into from
Jun 10, 2019

Conversation

jgosmann
Copy link
Collaborator

@jgosmann jgosmann commented Jun 10, 2019

Motivation and context:
This add some things that were missing in the docs, also see #228

Interactions with other PRs:
none

How has this been tested?
build and looked at the documentation

How long should this take to review?

  • Quick (less than 40 lines changed or changes are straightforward)

Types of changes:

  • Non-code change (touches things like tests, documentation, build scripts)

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • I have updated the documentation accordingly.
  • I have included a changelog entry.
  • [n/a] I have added tests to cover my changes.
  • [n/a] I have run the test suite locally and all tests passed.

@jgosmann jgosmann marked this pull request as ready for review June 10, 2019 08:02
@jgosmann jgosmann added this to the 0.6.2 milestone Jun 10, 2019
@jgosmann
Copy link
Collaborator Author

@tbekolay I don't have permissions to merge PRs. 😢

@tbekolay
Copy link
Member

tbekolay commented Jun 10, 2019 via email

@tbekolay
Copy link
Member

The issue was a branch protection setting, you should be able to merge now

@jgosmann jgosmann merged commit 5c8ca8d into master Jun 10, 2019
@jgosmann jgosmann deleted the missing-docs branch June 22, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants