Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix action selection key iteration. #210

Merged
merged 1 commit into from
Aug 30, 2018
Merged

Fix action selection key iteration. #210

merged 1 commit into from
Aug 30, 2018

Conversation

jgosmann
Copy link
Collaborator

@jgosmann jgosmann commented Aug 30, 2018 •
edited
Loading

Motivation and context:

It was failing without a named action.

Interactions with other PRs:

none

How has this been tested?

added tests

How long should this take to review?

  • Quick (less than 40 lines changed or changes are straightforward)

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • [n/a] I have updated the documentation accordingly.
  • I have included a changelog entry.
  • I have added tests to cover my changes.
  • I have run the test suite locally and all tests passed.

@jgosmann jgosmann added the bug label Aug 30, 2018
@jgosmann jgosmann added this to the 0.6 milestone Aug 30, 2018
@jgosmann jgosmann requested a review from Seanny123 August 30, 2018 16:32
@jgosmann jgosmann force-pushed the fix-actionsel-keys branch from 7f14b3b to 352674c Compare August 30, 2018 16:34
Seanny123
Seanny123 approved these changes Aug 30, 2018
View reviewed changes
Copy link
Collaborator

@Seanny123 Seanny123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Off-by-one errors!

@jgosmann
Copy link
Collaborator Author

Not exactly ... it was an uninitialized variable.

@jgosmann
Fix action selection key iteration.
1020d44 
It was failing without a named action.
@jgosmann jgosmann force-pushed the fix-actionsel-keys branch from 352674c to 1020d44 Compare August 30, 2018 19:54
@jgosmann jgosmann merged commit d8ba057 into master Aug 30, 2018
@jgosmann jgosmann deleted the fix-actionsel-keys branch August 30, 2018 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seanny123 Seanny123 Seanny123 approved these changes

Assignees
No one assigned
Labels
bug
Milestone
0.6
Development

Successfully merging this pull request may close these issues.
2 participants
@jgosmann @Seanny123