-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different ways to generate Semantic Pointers #201
Conversation
Use the vector_generation generators instead.
I'm still waiting on a review for this PR. |
Could there be some basic parameter validation on the For example, the case:
|
I have to look into it. We want to avoid starting the iteration (because then we'd consume an element, which is a problem especially with |
Turns out Nengo has |
Motivation and context:
This PR adds a number of generators to generate vectors for Semantic Pointers. These can be passed to a
Vocabulary
to specify how new Semantic Pointers should be generated. This allows to easily create vocabularies with all unitary, orthogonal, or axis-aligned vectors. It also gives the user the possibility to program custom generation methods.This removes the possibility to create a random pointer with
SemanticPointer(d)
. Not sure if this has been widely used and if some short-form syntax should be put back in. With this PR one can doSemanticPointer(next(UnitLengthVectors(d)))
) instead.Closes #129.
Interactions with other PRs:
Based on #198 which introduces some changes to the code touched, but it is not essential to this PR.
How has this been tested?
Added and existing tests.
How long should this take to review?
Types of changes:
Checklist:
Still to do: