Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cnmf extension for component eval #20

Closed
kushalkolar opened this issue May 22, 2022 · 4 comments · Fixed by #87
Closed

add cnmf extension for component eval #20

kushalkolar opened this issue May 22, 2022 · 4 comments · Fixed by #87
Milestone

Comments

@kushalkolar
Copy link
Collaborator

component evaluation should be done here within the backend, not in mesmerize-napari. write a cnmf extension that wraps cnmf_obj.estimates.filter_components.

Should it store this as a new batch item in the dataframe or update an existing item and just update the eval_kwargs of the params? @ArjunPutcha thoughts?

@ArjunPutcha
Copy link
Collaborator

I would think update eval kwargs within same item. Number of rows would get out of hand if we create a new batch item for each update of eval components (especially with update_live)

@ArjunPutcha
Copy link
Collaborator

Should we create a separate button to specifically save new eval kwargs, set it to save only when eval gui is closed/window is closed (so save most recent choice of eval kwargs), or continuously save as updates occur. I would think the first two options are better (preferably the first).

@kushalkolar
Copy link
Collaborator Author

I would think update eval kwargs within same item. Number of rows would get out of hand if we create a new batch item for each update of eval components (especially with update_live)

Good idea. It should only be saved after the user saves whatever they're happy with. We can add a flag to the params dict that indicates if eval components has been run on it by the user?

@kushalkolar
Copy link
Collaborator Author

Should we create a separate button to specifically save new eval kwargs, set it to save only when eval gui is closed/window is closed (so save most recent choice of eval kwargs), or continuously save as updates occur. I would think the first two options are better (preferably the first).

We should have an explicit save button

@kushalkolar kushalkolar added this to the v0.1 milestone Jul 3, 2022
@kushalkolar kushalkolar mentioned this issue Jul 3, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants