-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cnmf extension for component eval #20
Comments
I would think update eval kwargs within same item. Number of rows would get out of hand if we create a new batch item for each update of eval components (especially with update_live) |
Should we create a separate button to specifically save new eval kwargs, set it to save only when eval gui is closed/window is closed (so save most recent choice of eval kwargs), or continuously save as updates occur. I would think the first two options are better (preferably the first). |
Good idea. It should only be saved after the user saves whatever they're happy with. We can add a flag to the params dict that indicates if eval components has been run on it by the user? |
We should have an explicit save button |
component evaluation should be done here within the backend, not in mesmerize-napari. write a cnmf extension that wraps
cnmf_obj.estimates.filter_components
.Should it store this as a new batch item in the dataframe or update an existing item and just update the eval_kwargs of the params? @ArjunPutcha thoughts?
The text was updated successfully, but these errors were encountered: