-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: uses in composite #793
Feature: uses in composite #793
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I'm confused,
|
Wow removing Oh maybe remove setup-node from tests will solve this.... |
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #793 +/- ##
==========================================
+ Coverage 49.27% 57.05% +7.78%
==========================================
Files 23 28 +5
Lines 2401 4222 +1821
==========================================
+ Hits 1183 2409 +1226
- Misses 1090 1605 +515
- Partials 128 208 +80
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
@ChristopherHX this pull request has failed checks 🛠 |
@ChristopherHX this pull request is now in conflict 😩 |
1903876
@ChristopherHX this pull request has failed checks 🛠 |
Please help me, what is wrong with superlinter? It just crashs because a file is missing? I resolved the merge conflict of today. |
@ChristopherHX it's broken, don't worry about your update |
@ChristopherHX this pull request is now in conflict 😩 |
🎉 |
@catthehacker any chance of getting a new release with this in? 🙏🏻 |
Remove the old hack for composite run steps, use the real runcontext directly.
You can also enable if's in composite, I plan to enable it in https://github.com/ChristopherHX/github-act-runner by default.If's are now enabled see https://github.com/actions/runner/releases/tag/v2.284.0
Resolves #783
Resolves #926
This change seems to be functional complete.
Multi nested composite needs more Tests, maybe the size will get xl after more tests are added.