Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: uses in composite #793

Merged
merged 56 commits into from
Dec 22, 2021

Conversation

ChristopherHX
Copy link
Contributor

@ChristopherHX ChristopherHX commented Aug 30, 2021

Remove the old hack for composite run steps, use the real runcontext directly.
You can also enable if's in composite, I plan to enable it in https://github.com/ChristopherHX/github-act-runner by default.
If's are now enabled see https://github.com/actions/runner/releases/tag/v2.284.0

Resolves #783
Resolves #926

This change seems to be functional complete.
Multi nested composite needs more Tests, maybe the size will get xl after more tests are added.

@mergify

This comment has been minimized.

@mergify mergify bot added the needs-work Extra attention is needed label Aug 30, 2021
@mergify

This comment has been minimized.

@mergify

This comment has been minimized.

@mergify

This comment has been minimized.

@mergify

This comment has been minimized.

@mergify

This comment has been minimized.

@mergify

This comment has been minimized.

@mergify

This comment has been minimized.

@ChristopherHX
Copy link
Contributor Author

I'm confused,

  • the runner doesn't log the exit code of the tests
  • Check failure on linux/macOS, doesn't contains FAIL in the log either
  • No idea what to try next, is this fail due to the actions/runner???

@ChristopherHX
Copy link
Contributor Author

ChristopherHX commented Aug 30, 2021

Wow removing -v from gotest let it succeed (https://github.com/ChristopherHX/act/runs/3462707672?check_suite_focus=true)
Here the same workflow run with -v https://github.com/ChristopherHX/act/runs/3462703235?check_suite_focus=true and it fails.

Oh maybe remove setup-node from tests will solve this....

@mergify

This comment has been minimized.

@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #793 (99b21b3) into master (0f04942) will increase coverage by 7.78%.
The diff coverage is 64.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #793      +/-   ##
==========================================
+ Coverage   49.27%   57.05%   +7.78%     
==========================================
  Files          23       28       +5     
  Lines        2401     4222    +1821     
==========================================
+ Hits         1183     2409    +1226     
- Misses       1090     1605     +515     
- Partials      128      208      +80     
Impacted Files Coverage Δ
pkg/common/executor.go 46.90% <0.00%> (+2.03%) ⬆️
pkg/common/job_error.go 0.00% <0.00%> (ø)
pkg/common/outbound_ip.go 0.00% <0.00%> (ø)
pkg/common/testflag.go 0.00% <0.00%> (ø)
pkg/container/docker_volume.go 0.00% <0.00%> (ø)
pkg/model/action.go 0.00% <0.00%> (ø)
pkg/container/docker_run.go 5.54% <14.15%> (+3.61%) ⬆️
pkg/common/git.go 49.82% <31.81%> (-9.97%) ⬇️
pkg/runner/logger.go 65.43% <37.50%> (+1.28%) ⬆️
pkg/container/docker_auth.go 45.00% <45.00%> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ef30c3...99b21b3. Read the comment docs.

@mergify mergify bot removed the needs-work Extra attention is needed label Aug 30, 2021
@mergify

This comment has been minimized.

@mergify mergify bot added the needs-work Extra attention is needed label Aug 30, 2021
@mergify mergify bot removed the needs-work Extra attention is needed label Aug 30, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 22, 2021

@ChristopherHX this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Dec 22, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 22, 2021

@ChristopherHX this pull request is now in conflict 😩

@mergify mergify bot added the conflict PR has conflicts label Dec 22, 2021
@ChristopherHX ChristopherHX dismissed stale reviews from cplee and catthehacker via 1903876 December 22, 2021 08:17
@mergify mergify bot removed the conflict PR has conflicts label Dec 22, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 22, 2021

@ChristopherHX this pull request has failed checks 🛠

@ChristopherHX
Copy link
Contributor Author

Please help me, what is wrong with superlinter? It just crashs because a file is missing?
https://github.com/nektos/act/runs/4604475831?check_suite_focus=true

I resolved the merge conflict of today.

@catthehacker
Copy link
Member

@ChristopherHX it's broken, don't worry about your update

@catthehacker
Copy link
Member

@mergify
Copy link
Contributor

mergify bot commented Dec 22, 2021

@ChristopherHX this pull request is now in conflict 😩

@mergify mergify bot added the conflict PR has conflicts label Dec 22, 2021
@mergify mergify bot removed the conflict PR has conflicts label Dec 22, 2021
@mergify mergify bot removed the needs-work Extra attention is needed label Dec 22, 2021
@mergify mergify bot requested a review from a team December 22, 2021 19:01
@mergify mergify bot merged commit 9868e13 into nektos:master Dec 22, 2021
@catthehacker
Copy link
Member

🎉

@davetapley
Copy link
Contributor

@catthehacker any chance of getting a new release with this in? 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL stale-exempt Exempt from stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue: Bug running composite actions Using "uses" inside composite action
7 participants