You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I feel like a mention of this new function in the original package in the README.md is probably merited.
There is some difference in the two APIs of the two packages; this one has a WithContextN(ctx, numG, qSize) function whereas that one has just WithContext(ctx) and SetLimit(n) functions. At a glance it seems like the n in the original pretty similar to the numG parameter here, and there doesn't seem to be a qSize parameter in the original package. I definitely have not compared the two packages in detail, or really even attempted to understand the implementation of either one. I am just an end-user.
I used this package some time ago at a previous job (maybe two of them, actually, I can't quite remember) and it was helpful for my purposes, so thank you for that. Ultimately, I'm wondering now if using this package in new code is necessary or recommended, given the new SetLimit function in the original package, and would appreciate hearing any thoughts from more knowledgeable sources.
The text was updated successfully, but these errors were encountered:
It looks like the
sync/errgroup
package now has aSetLimit
function. You can see the documentation at https://pkg.go.dev/golang.org/x/sync/errgroup#Group.SetLimit . I believe that this is a fairly recent happening.I feel like a mention of this new function in the original package in the
README.md
is probably merited.There is some difference in the two APIs of the two packages; this one has a
WithContextN(ctx, numG, qSize)
function whereas that one has justWithContext(ctx)
andSetLimit(n)
functions. At a glance it seems like then
in the original pretty similar to thenumG
parameter here, and there doesn't seem to be aqSize
parameter in the original package. I definitely have not compared the two packages in detail, or really even attempted to understand the implementation of either one. I am just an end-user.I used this package some time ago at a previous job (maybe two of them, actually, I can't quite remember) and it was helpful for my purposes, so thank you for that. Ultimately, I'm wondering now if using this package in new code is necessary or recommended, given the new
SetLimit
function in the original package, and would appreciate hearing any thoughts from more knowledgeable sources.The text was updated successfully, but these errors were encountered: