-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking React 17 changes #1035
Comments
Link to the changes? |
https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html
|
Oh I thought it was something new. I'm aware of this, thanks. I don't think a branch is necessary |
Is your feature request related to a problem? Please describe.
A lot of lifecycle + server side rendering changes are occurring in React 16. It would be nice to have a branch of RNW that builds towards those changes (and is a breaking version change that supports
react: ^0.16
)Describe alternatives you've considered
It is hard to do stuff like
render = React.version.minor >= 16 ? ReactDom.hydrate : ReactDom.render
Additional context
A sep branch would be nice because the changes of all component lifecycles to the new approach I'm sure will take time, and need to trace changes to the master branch
[Edit]
I realized that you swap
hydrate
forrender
based onprocess.env.NODE_ENV
. Maybe for the time being would you consider allowing to pass in arenderFn
so users can default tohydrate
?Related Warning:
The text was updated successfully, but these errors were encountered: