Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document inotify config for kind deployments #496

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Document inotify config for kind deployments #496

wants to merge 3 commits into from

Conversation

asmacdo
Copy link

@asmacdo asmacdo commented Aug 6, 2024

Fixes #495

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

@netlify Netlify
Copy link

netlify bot commented Aug 6, 2024 •
edited
Loading

✅ Deploy Preview for nebari-docs ready!

Name Link
🔨 Latest commit 1b0ae94
🔍 Latest deploy log https://app.netlify.com/sites/nebari-docs/deploys/66f5881f9255210008711fa7
😎 Deploy Preview https://deploy-preview-496--nebari-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asmacdo asmacdo mentioned this pull request Aug 7, 2024
Open
12 tasks
kcpevey
kcpevey requested changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@kcpevey kcpevey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @asmacdo! Thank you for this contribution! I had a few minor changes to request.

docs/docs/how-tos/nebari-local.md
Depending on your host system, you may need to increase the `fs.inotify.max_user_watches` and
`fs.inotify.max_user_instances kernel parameters` if you see a `too many open files` in the logs of
a failing pod.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add the fixer snippet that you listed in the issue? I think that would be beneficial.

sudo sysctl fs.inotify.max_user_watches=524288      
sudo sysctl fs.inotify.max_user_instances=512

docs/docs/how-tos/nebari-local.md Outdated Show resolved Hide resolved
docs/docs/how-tos/nebari-local.md Outdated Show resolved Hide resolved
@asmacdo @kcpevey
Apply suggestions from code review
1b0ae94 
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcpevey kcpevey kcpevey requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
📖 - Documentation
Status: Todo 📬
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC] - Add troubleshooting doc for "too many open files" in kind cluster
2 participants
@asmacdo @kcpevey