Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nearcore 1.37 #164

Closed
telezhnaya opened this issue Jan 29, 2024 · 3 comments
Closed

Support nearcore 1.37 #164

telezhnaya opened this issue Jan 29, 2024 · 3 comments
Assignees

Comments

@telezhnaya
Copy link
Collaborator

We need to adapt to new or changed RPC methods.

More details: https://github.com/near/nearcore/blob/447572bb775a5954ca7a5a4b65c85b45aab9e499/chain/jsonrpc/CHANGELOG.md#023
Copy-pasting the most important parts here

Added send_tx method which gives configurable execution guarantees options and potentially replaces existing broadcast_tx_async, broadcast_tx_commit
Field final_execution_status is presented in the response of methods tx, EXPERIMENTAL_tx_status, broadcast_tx_commit, send_tx
Allowed use json in request for methods EXPERIMENTAL_tx_status, tx, broadcast_tx_commit, broadcast_tx_async, send_tx
Parameter wait_until (same entity as final_execution_status in the response) is presented as optional request parameter for methods EXPERIMENTAL_tx_status, tx, send_tx. The response will be returned only when the desired level of finality is reached
Breaking changes

Removed EXPERIMENTAL_check_tx method. Use tx method instead
Removed EXPERIMENTAL_broadcast_tx_sync method. Use send_tx method instead

The updates timeline: near/nearcore#10404

With the fact that we don't support non-finalised data yet, final_execution_status field can be always filled with FINAL. OFK, this logic will be more complicated when we add support of optimistic blocks.

@telezhnaya telezhnaya changed the title Support 1.37 Support nearcore 1.37 Jan 29, 2024
@kobayurii kobayurii self-assigned this Feb 8, 2024
@kobayurii
Copy link
Member

#169

@kobayurii
Copy link
Member

#195

@kobayurii
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants