Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[resharding] Add flat storage support #9207

Closed
Longarithm opened this issue Jun 15, 2023 · 1 comment
Closed

[resharding] Add flat storage support #9207

Longarithm opened this issue Jun 15, 2023 · 1 comment
Assignees
@shreyan-gupta
Labels
A-storage Area: storage and databases T-core Team: issues relevant to the core team

Comments

@Longarithm
Copy link
Member

Longarithm commented Jun 15, 2023 •
edited by shreyan-gupta
Loading

Flat storage is currently not aware of new shards (shard uids) appearing on the node, thus it doesn't create flat states for new shards. When we do resharding, we must to support flat storage as well. Reconstructing it from Trie was long and inefficient.

Known issues:

  • I don't know how some existing tests pass now because flat storage for new shards shouldn't be created
  • @nikurt said that Nayduck test sanity/state_sync_fail.py triggers resharding and stops working
  • maybe there are other testcases currently commented, we need to revive and fix them.
@Longarithm Longarithm added A-storage Area: storage and databases T-core Team: issues relevant to the core team labels Jun 15, 2023
@Longarithm Longarithm mentioned this issue Jun 15, 2023
Closed
@Longarithm Longarithm changed the title Support resharding for flat storage [Resharding] Add flat storage support Jun 15, 2023
@shreyan-gupta shreyan-gupta changed the title [Resharding] Add flat storage support [resharding] Add flat storage support Aug 11, 2023
@shreyan-gupta shreyan-gupta self-assigned this Aug 11, 2023
@shreyan-gupta shreyan-gupta mentioned this issue Aug 11, 2023
Closed
@shreyan-gupta
Copy link
Contributor

Working on this #9418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shreyan-gupta shreyan-gupta

Labels
A-storage Area: storage and databases T-core Team: issues relevant to the core team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Longarithm @shreyan-gupta