Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View structs should not be used on the protocol level #4159

Open
bowenwang1996 opened this issue Mar 24, 2021 · 2 comments
Open

View structs should not be used on the protocol level #4159

bowenwang1996 opened this issue Mar 24, 2021 · 2 comments
Labels
A-chain Area: Chain, client & related C-enhancement Category: An issue proposing an enhancement or a PR with one. T-core Team: issues relevant to the core team

Comments

@bowenwang1996
Copy link
Collaborator

All the view structs core/primitives/src/views.rs should only be used for rpc purposes and should not be used on the protocol level for other things. However, today EpochSyncResponse uses LightClientBlockView.
@bowenwang1996 bowenwang1996 added the A-chain Area: Chain, client & related label Mar 24, 2021
@bowenwang1996 bowenwang1996 added T-core Team: issues relevant to the core team C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Jun 28, 2021
@stale
Copy link

stale bot commented Sep 27, 2021

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Sep 27, 2021
@stale
Copy link

stale bot commented Dec 27, 2021

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Dec 27, 2021
@bowenwang1996 bowenwang1996 mentioned this issue Jan 22, 2022
Open
4 tasks
@akhi3030 akhi3030 removed the S-pinned label Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-chain Area: Chain, client & related C-enhancement Category: An issue proposing an enhancement or a PR with one. T-core Team: issues relevant to the core team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akhi3030 @Kouprin @bowenwang1996