New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tracking] Phase 1 Protocol Changes #2778

Closed

4 of 5 tasks

MaksymZavershynskyi opened this issue Jun 3, 2020 · 5 comments

Closed

4 of 5 tasks

[Tracking] Phase 1 Protocol Changes #2778

MaksymZavershynskyi opened this issue Jun 3, 2020 · 5 comments

Labels

C-epic

Contributor

MaksymZavershynskyi commented Jun 3, 2020 •

edited by ilblackdragon

Loading

The following protocol changes need to land before Phase 1 launch and also before we turn on the enforcement of the forward compatibility.

Fix of million proposal attack, see: Excessive copying of ValidatorStake in epoch manager #2610 CC @bowenwang1996
Fix of the receipt congestion attack, see: [discussion] Dynamic gas price during transaction execution NEPs#67 CC @evgenykuzyakov
Re-evaluate fee estimation after @mikhailOK disabled state caching: feat(storage): Trie cache limit on value cached #2770 CC @olonho
Add the fee for loading the contract into memory CC @olonho Add the fee for loading the contract into memory #2777
Overflow of gas price @bowenwang1996

MaksymZavershynskyi added the C-epic label

Collaborator

bowenwang1996 commented Jun 3, 2020

#2770 doesn't disable state caching entirely. It disables caching of large values.

Contributor Author

MaksymZavershynskyi commented Jun 3, 2020

@mikhailOK Can we extend the no_cache compiler flag to disable all caching in the state?

Collaborator

bowenwang1996 commented Jun 3, 2020

@nearmax what about near/NEPs#79?

Contributor

mikhailOK commented Jun 3, 2020

no_cache flag sets cache size to 1

Collaborator

bowenwang1996 commented Jul 6, 2020

@nearmax can we close this now?

MaksymZavershynskyi closed this as completed

MaksymZavershynskyi mentioned this issue

Fix no_cache feature and recompute fees #2948

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment