Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical UX/DevX issues checklist #2518

Closed
3 of 5 tasks
vgrichina opened this issue Apr 23, 2020 · 8 comments
Closed
3 of 5 tasks

Critical UX/DevX issues checklist #2518

vgrichina opened this issue Apr 23, 2020 · 8 comments
Labels
C-epic Category: an epic

Comments

@vgrichina
Copy link
Collaborator

vgrichina commented Apr 23, 2020

@vgrichina vgrichina added the C-epic Category: an epic label Apr 23, 2020
@vgrichina vgrichina changed the title Critical UX/DevX issues Critical UX/DevX issues checklist Apr 23, 2020
@vgrichina
Copy link
Collaborator Author

vgrichina commented Apr 24, 2020

not sure who checked 2488 checkbox, but let's mark only stuff that is in production (and verified at app level) as "fixed" for purposes of this tracker

@bowenwang1996
Copy link
Collaborator

@vgrichina that is fair, but can you verify that it works now on betanet?

@vgrichina
Copy link
Collaborator Author

@bowenwang1996 looks fine on betanet, except doesn't seem to be returning structured error:

[I] ➜ NODE_ENV=betanet near  tx-status DtPxTahaRwyG7pXYBUBQT5soFYjSJmrwnRsYfNkcQ1bb --accountId test_contract1586245860963186
Using options: {
  accountId: 'test_contract1586245860963186',
  networkId: 'betanet',
  nodeUrl: 'https://rpc.betanet.nearprotocol.com',
  contractName: undefined,
  walletUrl: 'https://wallet.betanet.nearprotocol.com',
  helperUrl: 'https://helper.betanet.nearprotocol.com',
  hash: 'DtPxTahaRwyG7pXYBUBQT5soFYjSJmrwnRsYfNkcQ1bb'
}
Error:  TypedError: [-32000] Server error: Transaction DtPxTahaRwyG7pXYBUBQT5soFYjSJmrwnRsYfNkcQ1bb doesn't exist
    at JsonRpcProvider.sendJsonRpc (/Users/vg/.config/yarn/global/node_modules/near-api-js/lib/providers/json-rpc-provider.js:113:27)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async /Users/vg/.config/yarn/global/node_modules/near-shell/commands/tx-status.js:33:24
    at async Object.handler (/Users/vg/.config/yarn/global/node_modules/near-shell/utils/exit-on-error.js:4:9) {
  type: 'UntypedError'
}

@bowenwang1996
Copy link
Collaborator

@vgrichina is this an issue on nearcore side or near-api-js side?

@vgrichina
Copy link
Collaborator Author

vgrichina commented Apr 27, 2020

@bowenwang1996 on nearcore side:

[I] ➜ http post https://rpc.betanet.nearprotocol.com jsonrpc=2.0 method=tx params:='["CqiBnYCRgkGV2odJPXJTBkoZHXjDNQFJKw7oRYWU1j6g", "betanet"]' id=dontcare
HTTP/1.1 200 OK
Connection: keep-alive
Content-Length: 162
Content-Type: application/json
Date: Mon, 27 Apr 2020 23:14:13 GMT
Server: nginx/1.14.0 (Ubuntu)

{
    "error": {
        "code": -32000,
        "data": "Transaction CqiBnYCRgkGV2odJPXJTBkoZHXjDNQFJKw7oRYWU1j6g doesn't exist",
        "message": "Server error"
    },
    "id": "dontcare",
    "jsonrpc": "2.0"
}

@frol
Copy link
Collaborator

frol commented Apr 28, 2020

@fckt Can you help us to set up the errors to be structured?

@stale
Copy link

stale bot commented Jul 1, 2021

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Jul 1, 2021
@bowenwang1996
Copy link
Collaborator

Looks like only the near-api-js one is still open. Closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-epic Category: an epic
Projects
None yet
Development

No branches or pull requests

3 participants