config: adjust shard cache sizes #10409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10409 +/- ##
==========================================
- Coverage 72.00% 71.90% -0.11%
==========================================
Files 718 719 +1
Lines 144544 144914 +370
Branches 144544 144914 +370
==========================================
+ Hits 104080 104199 +119
- Misses 35705 35942 +237
- Partials 4759 4773 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wacban
approved these changes
Jan 12, 2024
| @@ -240,17 +240,22 @@ impl Default for StoreConfig { | |||
| block_size: bytesize::ByteSize::kib(16), | |||
|
|
|||
| trie_cache: TrieCacheConfig { | |||
| default_max_bytes: DEFAULT_SHARD_CACHE_TOTAL_SIZE_LIMIT, | |||
| default_max_bytes: 500_000_000, | |||
There was a problem hiding this comment.
not for this pr, but bytesize is a nice type safe helper for dealing with bytes
core/store/src/config.rs
Outdated
Comment on lines
251
to
253
| (ShardUId { version: 1, shard_id: 3 }, 3_000_000_000), | ||
| // After resharding "token.sweat" account moves to shard 4 | ||
| (ShardUId { version: 2, shard_id: 4 }, 3_000_000_000), |
There was a problem hiding this comment.
nit:
// In simple nightshade the heavy contract "token.sweat" is in shard 3
(ShardUId { version: 1, shard_id: 3 }, 3_000_000_000),
// In simple nightshade v2 the heavy contract "token.sweat" is in shard 4
(ShardUId { version: 2, shard_id: 4 }, 3_000_000_000),
Comment on lines
+256
to
+257
| (ShardUId { version: 1, shard_id: 1 }, 50_000_000), | ||
| (ShardUId { version: 2, shard_id: 1 }, 50_000_000), |
There was a problem hiding this comment.
Isn't it the default now? Does it need to be set explicitly?
There was a problem hiding this comment.
nope, I've changed the default via default_max_bytes field above to 500MB
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 12, 2024
As suggested in #10409 (comment) to keep it consistent with the rest of `StoreConfig`.
posvyatokum
pushed a commit
that referenced
this pull request
Jan 22, 2024
* Do not apply default size increase introduced in #10373 to `view_trie_cache` since view calls are not latency-sensitive * Opt out shard 1 from the increase since it only contains aurora account and based on the current metrics has very low cache miss rate even with a size of 50MB * Configure shard 3 override of 3GB to also apply after resharding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
view_trie_cachesince view calls are not latency-sensitive