-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MSRV check to CI #106
Comments
FWIW, I’ve recently written down my current thoughts on MSRV here: matklad/once_cell#201 |
Hmm, I completely understand the viewpoint, and maybe we make no guarantees about bumping msrv during minor/patch versions, but is it not still beneficial to have this msrv controlled and visible? Feel free to close, I don't have an actual opinion on this |
Crates should document their MSRV policy, and, if the policy is different from "latest stable" it should be tested on CI. I am not entirely sure what's the right MSRV policy for borsh, the following makes sense to me:
If we have abundance of resources, 2 year MSRV would also make sense to me If we are very short on resources, I think declaring "latest stable" won't be catastrophic either. |
taking this for trial and error and resolution |
Currently, changes can bump the MSRV without noticing. Would be good to have this documented and stable for #51.
Noticed from #104 bumping MSRV without any failing CI
The text was updated successfully, but these errors were encountered: