Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MSRV check to CI #106

Closed
austinabell opened this issue Sep 27, 2022 · 4 comments · Fixed by #151
Closed

Add MSRV check to CI #106

austinabell opened this issue Sep 27, 2022 · 4 comments · Fixed by #151
Labels
good first issue Good for newcomers

Comments

@austinabell
Copy link
Contributor

Currently, changes can bump the MSRV without noticing. Would be good to have this documented and stable for #51.

Noticed from #104 bumping MSRV without any failing CI

@austinabell austinabell added the good first issue Good for newcomers label Sep 27, 2022
@matklad
Copy link
Contributor

matklad commented Sep 27, 2022

FWIW, I’ve recently written down my current thoughts on MSRV here: matklad/once_cell#201

@austinabell
Copy link
Contributor Author

Hmm, I completely understand the viewpoint, and maybe we make no guarantees about bumping msrv during minor/patch versions, but is it not still beneficial to have this msrv controlled and visible?

Feel free to close, I don't have an actual opinion on this

@matklad
Copy link
Contributor

matklad commented Sep 28, 2022

Crates should document their MSRV policy, and, if the policy is different from "latest stable" it should be tested on CI.

I am not entirely sure what's the right MSRV policy for borsh, the following makes sense to me:

  • MSRV is not breaking
  • MSRV is six months at least
  • explicit non-support for debian stable and such
  • newer compilers can be used if required by a feature (cosnt-generics) or via feacher-checking in build.rs (eg, via rustc-version or autocfg crates).

If we have abundance of resources, 2 year MSRV would also make sense to me

If we are very short on resources, I think declaring "latest stable" won't be catastrophic either.

@dj8yfo
Copy link
Collaborator

dj8yfo commented Jun 19, 2023

taking this for trial and error and resolution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants