Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker build failing? #16

Open
DbCrWk opened this issue Jan 6, 2025 · 3 comments
Open

Docker build failing? #16

DbCrWk opened this issue Jan 6, 2025 · 3 comments

Comments

@DbCrWk
Copy link

DbCrWk commented Jan 6, 2025

This action is great! However, this action just stopped running due to some (cryptic) Docker failure. I wonder if it's related to the release of Poetry 2?

Our Action YAML File

name: Poetry Diff
on: [pull_request]

jobs:
    poetry-dff:
        runs-on: ubuntu-latest
        steps:
            - uses: webfactory/ssh-agent@v0.9.0
              with:
                  ssh-private-key: ${{ secrets.PRIVATE_SSH_KEY }}

            - name: Checkout
              uses: actions/checkout@v4

            - name: Install Poetry
              run: |
                  pipx install poetry==1.8.3

            - name: Set up Python
              uses: actions/setup-python@v5
              with:
                  python-version: 3.10.12
                  cache: poetry

            - name: Poetry Diff
              uses: nborrmann/diff-poetry-lock@main

Build Log from Github Action Run

2_Build nborrmann_diff-poetry-lock@main.txt

@tiagovrtr
Copy link

We have also experienced this across multiple repositories today with no associated changes, even to SHA-pinned action steps

@tiagovrtr
Copy link

This action is great! However, this action just stopped running due to some (cryptic) Docker failure. I wonder if it's related to the release of Poetry 2?

Our Action YAML File

name: Poetry Diff
on: [pull_request]

jobs:
    poetry-dff:
        runs-on: ubuntu-latest
        steps:
            - uses: webfactory/ssh-agent@v0.9.0
              with:
                  ssh-private-key: ${{ secrets.PRIVATE_SSH_KEY }}

            - name: Checkout
              uses: actions/checkout@v4

            - name: Install Poetry
              run: |
                  pipx install poetry==1.8.3

            - name: Set up Python
              uses: actions/setup-python@v5
              with:
                  python-version: 3.10.12
                  cache: poetry

            - name: Poetry Diff
              uses: nborrmann/diff-poetry-lock@main

Build Log from Github Action Run

2_Build nborrmann_diff-poetry-lock@main.txt

It looks almost certain this is the issue as the poetry package used in this action is not pinned:

RUN pip install poetry

@DbCrWk
Copy link
Author

DbCrWk commented Jan 6, 2025

It looks almost certain this is the issue as the poetry package used in this action is not pinned:

RUN pip install poetry

Good catch! Yes that must certainly be it. The timing of this action breaking right after a Poetry release was suspicious :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants