From c8328786f05cf357a07893c489cd4ecf020f6031 Mon Sep 17 00:00:00 2001 From: WoodNeck Date: Thu, 1 Sep 2022 14:25:14 +0900 Subject: [PATCH] chore: update packages versions --- .../projects/ngx-view3d/package-lock.json | 2 +- .../projects/ngx-view3d/package.json | 4 ++-- packages/react-view3d/package-lock.json | 2 +- packages/react-view3d/package.json | 4 ++-- packages/svelte-view3d/package-lock.json | 2 +- packages/svelte-view3d/package.json | 4 ++-- packages/view3d/package.json | 2 +- .../src/core/annotation/FaceAnnotation.ts | 18 +++++++++--------- packages/vue-view3d/package-lock.json | 2 +- packages/vue-view3d/package.json | 4 ++-- packages/vue3-view3d/package-lock.json | 2 +- packages/vue3-view3d/package.json | 4 ++-- 12 files changed, 25 insertions(+), 25 deletions(-) diff --git a/packages/ngx-view3d/projects/ngx-view3d/package-lock.json b/packages/ngx-view3d/projects/ngx-view3d/package-lock.json index 08d2ff0d..86205ae9 100644 --- a/packages/ngx-view3d/projects/ngx-view3d/package-lock.json +++ b/packages/ngx-view3d/projects/ngx-view3d/package-lock.json @@ -1,6 +1,6 @@ { "name": "@egjs/ngx-view3d", - "version": "2.0.1", + "version": "2.1.0", "lockfileVersion": 2, "requires": true, "packages": { diff --git a/packages/ngx-view3d/projects/ngx-view3d/package.json b/packages/ngx-view3d/projects/ngx-view3d/package.json index e6e57874..79216bba 100644 --- a/packages/ngx-view3d/projects/ngx-view3d/package.json +++ b/packages/ngx-view3d/projects/ngx-view3d/package.json @@ -1,6 +1,6 @@ { "name": "@egjs/ngx-view3d", - "version": "2.0.1", + "version": "2.1.0", "description": "Fast & Customizable glTF 3D model viewer, packed with full of features!", "sideEffects": [ "**/*.css", @@ -11,7 +11,7 @@ "@angular/core": ">=10.0.0" }, "dependencies": { - "@egjs/view3d": "~2.7.1" + "@egjs/view3d": "~2.8.0" }, "devDependencies": { "@angular/common": "~10.0.0", diff --git a/packages/react-view3d/package-lock.json b/packages/react-view3d/package-lock.json index c100189a..2615a311 100644 --- a/packages/react-view3d/package-lock.json +++ b/packages/react-view3d/package-lock.json @@ -1,6 +1,6 @@ { "name": "@egjs/react-view3d", - "version": "2.0.1", + "version": "2.1.0", "lockfileVersion": 2, "requires": true, "packages": { diff --git a/packages/react-view3d/package.json b/packages/react-view3d/package.json index d3d66ec8..09755629 100644 --- a/packages/react-view3d/package.json +++ b/packages/react-view3d/package.json @@ -1,6 +1,6 @@ { "name": "@egjs/react-view3d", - "version": "2.0.1", + "version": "2.1.0", "description": "Fast & Customizable glTF 3D model viewer, packed with full of features!", "main": "dist/view3d.cjs.js", "module": "dist/view3d.esm.js", @@ -19,7 +19,7 @@ "eject": "react-scripts eject" }, "dependencies": { - "@egjs/view3d": "~2.7.1" + "@egjs/view3d": "~2.8.0" }, "peerDependencies": { "react": ">=16.0.0" diff --git a/packages/svelte-view3d/package-lock.json b/packages/svelte-view3d/package-lock.json index 371c9ee1..4315aba7 100644 --- a/packages/svelte-view3d/package-lock.json +++ b/packages/svelte-view3d/package-lock.json @@ -1,6 +1,6 @@ { "name": "@egjs/svelte-view3d", - "version": "2.0.1", + "version": "2.1.0", "lockfileVersion": 2, "requires": true, "packages": { diff --git a/packages/svelte-view3d/package.json b/packages/svelte-view3d/package.json index 4c2ca17d..bd79b8ef 100644 --- a/packages/svelte-view3d/package.json +++ b/packages/svelte-view3d/package.json @@ -1,6 +1,6 @@ { "name": "@egjs/svelte-view3d", - "version": "2.0.1", + "version": "2.1.0", "description": "Fast & Customizable glTF 3D model viewer, packed with full of features!", "main": "dist/view3d.cjs.js", "module": "dist/view3d.esm.js", @@ -34,7 +34,7 @@ }, "license": "MIT", "dependencies": { - "@egjs/view3d": "~2.7.1" + "@egjs/view3d": "~2.8.0" }, "devDependencies": { "@egjs/build-helper": "^0.1.2", diff --git a/packages/view3d/package.json b/packages/view3d/package.json index eb0ec86c..67741ff8 100644 --- a/packages/view3d/package.json +++ b/packages/view3d/package.json @@ -1,6 +1,6 @@ { "name": "@egjs/view3d", - "version": "2.8.0-beta.2", + "version": "2.8.0", "description": "Fast & Customizable glTF 3D model viewer, packed with full of features!", "main": "dist/view3d.js", "module": "dist/view3d.esm.js", diff --git a/packages/view3d/src/core/annotation/FaceAnnotation.ts b/packages/view3d/src/core/annotation/FaceAnnotation.ts index 2b36182f..e9d0bd30 100644 --- a/packages/view3d/src/core/annotation/FaceAnnotation.ts +++ b/packages/view3d/src/core/annotation/FaceAnnotation.ts @@ -77,7 +77,7 @@ class FaceAnnotation extends Annotation { public unfocus(): void { if (!this._focusing) return; - this._destroyTrackingControl(); + this.destroyTrackingControl(); this._onUnfocus(); } @@ -105,7 +105,7 @@ class FaceAnnotation extends Annotation { if (view3D.annotationAutoUnfocus) { this.unfocus(); } else { - this._destroyTrackingControl(); + this.destroyTrackingControl(); } } @@ -119,17 +119,17 @@ class FaceAnnotation extends Annotation { }; } - private _destroyTrackingControl() { + public destroyTrackingControl() { const { control } = this._view3D; const trackingControl = this._trackingControl; - if (trackingControl) { - control.sync(); - control.remove(trackingControl); + if (!trackingControl) return; - trackingControl.destroy(); - this._trackingControl = null; - } + control.sync(); + control.remove(trackingControl); + + trackingControl.destroy(); + this._trackingControl = null; } private _getPosition(): THREE.Vector3 { diff --git a/packages/vue-view3d/package-lock.json b/packages/vue-view3d/package-lock.json index f8e6e8ca..97b2b08c 100644 --- a/packages/vue-view3d/package-lock.json +++ b/packages/vue-view3d/package-lock.json @@ -1,6 +1,6 @@ { "name": "@egjs/vue-view3d", - "version": "2.0.1", + "version": "2.1.0", "lockfileVersion": 2, "requires": true, "packages": { diff --git a/packages/vue-view3d/package.json b/packages/vue-view3d/package.json index 972207e6..8416c5e7 100644 --- a/packages/vue-view3d/package.json +++ b/packages/vue-view3d/package.json @@ -1,6 +1,6 @@ { "name": "@egjs/vue-view3d", - "version": "2.0.1", + "version": "2.1.0", "description": "Fast & Customizable glTF 3D model viewer, packed with full of features!", "main": "dist/view3d.cjs.js", "module": "dist/view3d.esm.js", @@ -38,7 +38,7 @@ "not op_mini all" ], "dependencies": { - "@egjs/view3d": "~2.7.1" + "@egjs/view3d": "~2.8.0" }, "peerDependencies": { "vue": "^2.0.0" diff --git a/packages/vue3-view3d/package-lock.json b/packages/vue3-view3d/package-lock.json index efb4d750..29c12552 100644 --- a/packages/vue3-view3d/package-lock.json +++ b/packages/vue3-view3d/package-lock.json @@ -1,6 +1,6 @@ { "name": "@egjs/vue3-view3d", - "version": "2.0.1", + "version": "2.1.0", "lockfileVersion": 2, "requires": true, "packages": { diff --git a/packages/vue3-view3d/package.json b/packages/vue3-view3d/package.json index 82b18cf6..ff460825 100644 --- a/packages/vue3-view3d/package.json +++ b/packages/vue3-view3d/package.json @@ -1,6 +1,6 @@ { "name": "@egjs/vue3-view3d", - "version": "2.0.1", + "version": "2.1.0", "description": "Fast & Customizable glTF 3D model viewer, packed with full of features!", "main": "dist/view3d.cjs.js", "module": "dist/view3d.esm.js", @@ -33,7 +33,7 @@ "not op_mini all" ], "dependencies": { - "@egjs/view3d": "~2.7.1" + "@egjs/view3d": "~2.8.0" }, "peerDependencies": { "vue": "^3.0.0"