Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table of contents doesn't print accents in uppercase letters at the title #3638

Open
MiniX16 opened this issue Aug 15, 2024 · 5 comments
Open
Assignees
Labels
bug We say this works but it doesn't P2 - minor feature or not urgent Minor bugs or less-popular features

Comments

@MiniX16
Copy link

MiniX16 commented Aug 15, 2024

Operating System Browser Renderer
Windows Other v3

What happened?

When creating the table of contets and trying to change its title to "Índice" (Index in spanish), the first "Í" with accent was printed without the accent.

@ericscheid ericscheid added the P2 - minor feature or not urgent Minor bugs or less-popular features label Aug 15, 2024
@ericscheid
Copy link
Collaborator

It would appear that the font MrsEavesRemake needs a glyph tweak.

image

@5e-Cleric
Copy link
Member

I wouldn't call a glyph tweak to adding all latin suplement uppercase characters, also have in mind, #116 is our oldest issue.

@MiniX16
Copy link
Author

MiniX16 commented Aug 18, 2024

Hey! I was trying to fix this as my first issue, I think I fixed it but still not working... Using a online visualizer of the font @ericscheid said I saw the problem:

image

So I decided to modify the font so it works as it should and this is the result:

image

So I replaced the font file here: /homebrewery/themes/fonts/5e/Mr Eaves Small Caps.woff2 and here /homebrewery/themes/fonts/5e legacy/Mr Eaves Small Caps.woff2, rebuild and run. Not workin :(

Any idea? Building is enough to see the changes, right? Did I modified the correct file?

@dbolack-ab
Copy link
Collaborator

Hey! I was trying to fix this as my first issue, I think I fixed it but still not working... Using a online visualizer of the font @ericscheid said I saw the problem:

image

So I decided to modify the font so it works as it should and this is the result:

image

So I replaced the font file here: /homebrewery/themes/fonts/e5/Mr Eaves Small Caps.woff2 and here /homebrewery/themes/fonts/e5 legacy/Mr Eaves Small Caps.woff2, rebuild and run. Not workin :(

Any idea? Building is enough to see the changes, right? Did I modified the correct file?

/homebrewery/themes/fonts/e5/Mr Eaves Small Caps.woff2 or
homebrewery/themes/fonts/5e/Mr Eaves Small Caps.woff2

@5e-Cleric
Copy link
Member

Do we want to modify the Legacy font? we can do it, but @MiniX16 for the future, you don't need to update anything in the legacy version. I believe there was consensus on leaving that as it, with bugs and all. I do think a font change this small won't break anything.

This looks good.

@5e-Cleric 5e-Cleric added the bug We say this works but it doesn't label Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug We say this works but it doesn't P2 - minor feature or not urgent Minor bugs or less-popular features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants