Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add share link to error page 401 if brew published #3298

Closed
5e-Cleric opened this issue Feb 13, 2024 · 3 comments · Fixed by #3399
Closed

Add share link to error page 401 if brew published #3298

5e-Cleric opened this issue Feb 13, 2024 · 3 comments · Fixed by #3399
Labels
❌ Missing from V3 This should be in v3 UI/UX User Interface, user experience

Comments

@5e-Cleric
Copy link
Member

As the published status boolean indicates the availability of the brew to the public, it would make sense to add a share link to the error 401 page if a brew is published.

@5e-Cleric 5e-Cleric added UI/UX User Interface, user experience ❌ Missing from V3 This should be in v3 labels Feb 13, 2024
@5e-Cleric 5e-Cleric changed the title Add share link to error page 401 if brew published Add share link to error page 401 or 403 if brew published Feb 13, 2024
@5e-Cleric 5e-Cleric changed the title Add share link to error page 401 or 403 if brew published Add share link to error page 401 if brew published Apr 7, 2024
@5e-Cleric 5e-Cleric linked a pull request Apr 7, 2024 that will close this issue
@calculuschild
Copy link
Member

After looking at @ericscheid 's comment on #3086, I think he has a point that this probably isn't necessary. A user who has an edit link should probably have the share link as well, whether the brew is published or not.

@5e-Cleric
Copy link
Member Author

If this is generally agreed, then the issue is done for, but there is still one page without share link, the PR will still be of use.

@calculuschild
Copy link
Member

calculuschild commented Apr 9, 2024

Which page is missing a share link?

Ah, the "you are not logged in" case. I see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❌ Missing from V3 This should be in v3 UI/UX User Interface, user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants