Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"latest" surveyor tag in docker and compatibility with latest version #52

Open
cartmast opened this issue Sep 1, 2021 · 4 comments
Open

Comments

@cartmast
Copy link

cartmast commented Sep 1, 2021

The "latest" docker tag and the default here results in

nats-surveyor | flag provided but not defined: -jetstream
nats-surveyor | Usage of /nats-surveyor:
nats-surveyor |   -a string
nats-surveyor |     	Network host to listen on. (default "0.0.0.0")
nats-surveyor |   -addr string

because of this line.

My .env file:

NATS_SURVEYOR_SERVERS=nats://redacted-for-git-post.elb.us-west-2.amazonaws.com:4222
NATS_SURVEYOR_CREDS=/path/to/system/creds/sys.creds
NATS_SURVEYOR_SERVER_COUNT=10

PROMETHEUS_STORAGE=./storage/prometheus

SURVEYOR_DOCKER_TAG=latest
PROMETHEUS_DOCKER_TAG=latest
GRAFANA_DOCKER_TAG=latest

This can be avoided with using 5c1dedbc... but this seems misleading based on default values in this code package and the README which does not list -jetstream as an option. Nor can you use the feature described here without the use of this flag...

So my question is: which tag should we be using? Can 5c1dedb be trusted as stable? Or should we be using the "latest" in which there is not JetStream support?

@ripienaar
Copy link
Collaborator

Yes as is common the main of a repo is what is being developed vs the tags showing what is released. As it stands we have not released a Surveyor with JS support.

@cartmast
Copy link
Author

cartmast commented Sep 2, 2021

Okay. Thanks for the clarification.

With respect to JS, is all that is missing a dashboard per issue #25?

@ripienaar
Copy link
Collaborator

No we have quite a lot missing to make a full featured monitoring capability. We have added much to the server in terms of new data but do not yet gather that.

If you want to play with what I have I can push a snapshot docker container with the commit ID of main. Leaving :latest as is

@cartmast
Copy link
Author

cartmast commented Sep 2, 2021

If you don't mind that would be great. I appreciate your help here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants