Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArgumentEscaper should escape empty string #227

Closed
ejball opened this issue Apr 25, 2019 · 2 comments · Fixed by #228
Closed

ArgumentEscaper should escape empty string #227

ejball opened this issue Apr 25, 2019 · 2 comments · Fixed by #228
Labels
bug help wanted We would be willing to take a well-written PR to help fix this.
Milestone
2.4.0-alpha

Comments

@ejball
Copy link
Contributor

ejball commented Apr 25, 2019

ArgumentEscaper.EscapeAndConcatenate effectively ignores empty strings. It would make more sense to escape them (as ""), but that would be a breaking change to anyone relying on the current behavior.

For what it's worth, this would fix it: ejball@0ed6092
@natemcmaster
Copy link
Owner

Would be happy to accept the fix as a PR :)

@natemcmaster natemcmaster added bug help wanted We would be willing to take a well-written PR to help fix this. labels Apr 27, 2019
@ejball ejball mentioned this issue Apr 27, 2019
Merged
@ejball
Copy link
Contributor Author

ejball commented Apr 27, 2019

Done. #228

@natemcmaster natemcmaster added this to the 2.4.0-alpha milestone Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted We would be willing to take a well-written PR to help fix this.
Projects
None yet
Milestone
2.4.0-alpha
Development

Successfully merging a pull request may close this issue.

Escape empty arguments. ejball/CommandLineUtils
2 participants
@ejball @natemcmaster