Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #131, Rename CommandCode variable to FcnCode #132

Closed

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Oct 19, 2022

Checklist

Describe the contribution

Testing performed
Standard cFS bundle tests all passed.
Build/run cFS and test NOOP and other commands with the GroundSystem tool. All working fine.

Expected behavior changes
No impact on behavior.
Improves code clarity and consistency in the lab apps.

System(s) tested on
Intel(R) Celeron(R) N4100 CPU @ 1.10GHz x86_64
Debian GNU/Linux 11 (bullseye)
cFE v7.0.0-rc4+dev197, OSAL v6.0.0-rc4+dev143, PSP v1.6.0-rc4+d
Sample App v1.3.0-rc4+dev35
CI Lab App v2.5.0-rc4+dev39
TO Lab v2.5.0-rc4+dev31

Contributor Info
Avi Weiss @thnkslprpt

@dzbaker
Copy link
Contributor

dzbaker commented Oct 20, 2022

@thnkslprpt CCB 20 October 2022: Approved pending resolution of failed workflow (squash commits?)

@dzbaker dzbaker added the CCB:Approved Indicates approval by CCB label Oct 20, 2022
@thnkslprpt thnkslprpt force-pushed the fix-131-rename-commandcode-variable branch from 8bde23e to 80d5903 Compare October 20, 2022 20:56
@dzbaker dzbaker added this to the Fornax milestone Nov 21, 2022
@dzbaker dzbaker modified the milestones: Fornax, Equuleus Dec 7, 2022
@thnkslprpt thnkslprpt closed this Nov 14, 2023
@thnkslprpt thnkslprpt force-pushed the fix-131-rename-commandcode-variable branch from 80d5903 to 2d7e01c Compare November 14, 2023 17:38
@thnkslprpt
Copy link
Contributor Author

Sorry - replaced with #171 (I still can't figure out how to deal with rebases that remove all changes, and then add back the actual changes from PR into 1 commit without closing the issue...)

@skliper
Copy link
Contributor

skliper commented Nov 14, 2023

@thnkslprpt - cherry-pick might be what you are looking for: https://git-scm.com/docs/git-cherry-pick. Allows you to apply just the changes in a specific commit.

@thnkslprpt thnkslprpt deleted the fix-131-rename-commandcode-variable branch April 25, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates approval by CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recommend using FcnCode (instead of CommandCode) terminology in the code
3 participants