Fix #217, Convert remaining int32 CFE status variables to CFE_Status_t
#218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
thnkslprpt
force-pushed
the
fix-217-convert-int32-cfe-variables-to-CFE_Status_t
branch
from
6bf6b80
to
1e903fb
Compare
| @@ -107,10 +107,10 @@ | |||
| /* Initialization */ | |||
| /* */ | |||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * **/ | |||
| int32 SAMPLE_APP_Init(void) | |||
| CFE_Status_t SAMPLE_APP_Init(void) | |||
Check notice
Code scanning / CodeQL-coding-standard
Function too long Note
| @@ -107,10 +107,10 @@ | |||
| /* Initialization */ | |||
| /* */ | |||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * **/ | |||
| int32 SAMPLE_APP_Init(void) | |||
| CFE_Status_t SAMPLE_APP_Init(void) | |||
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Mar 21, 2024
*Combines:* cFE equuleus-rc1+dev114 sample_app equuleus-rc1+dev46 **Includes:** *cFE* - nasa/cFE#2387 - nasa/cFE#2531 *sample_app* - nasa/sample_app#218 - nasa/sample_app#216 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
This was referenced Mar 21, 2024
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Mar 21, 2024
*Combines:* cFE equuleus-rc1+dev114 sample_app equuleus-rc1+dev46 **Includes:** *cFE* - nasa/cFE#2387 - nasa/cFE#2531 *sample_app* - nasa/sample_app#218 - nasa/sample_app#216 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
thnkslprpt
deleted the
fix-217-convert-int32-cfe-variables-to-CFE_Status_t
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
CFE_Status_t#217int32variables which hold CFE statuses converted to the more expressiveCFE_Status_tTesting performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).
Expected behavior changes
No change.
System(s) tested on
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS bundle.
Contributor Info
Avi Weiss @thnkslprpt