Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS_SymbolLookup Function Prototype Variable Names Do Not Match Implementation #185

Closed
skliper opened this issue Sep 30, 2019 · 2 comments
Closed

Comments

@skliper
Copy link
Contributor

skliper commented Sep 30, 2019

The OS_SymbolLookup function prototype (in osapi-os-loader.h) defines the prototype to be:

int32 OS_SymbolLookup (cpuaddr *symbol_address, const char *symbol_name );

While the implementations of this function declares the function with variable names that do not match the prototype:

int32 OS_SymbolLookup( cpuaddr *SymbolAddress, const char *SymbolName )

This could result in compiler errors/warnings on certain platforms. It is recommended to update the prototype variable names to match the implementations.

@skliper skliper self-assigned this Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Imported from trac issue 162. Created by sstrege on 2016-03-10T12:21:00, last modified: 2019-04-23T15:45:34

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by cdknight on 2018-07-24 13:57:19:

CCB determined this is not worth working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant