repeated assignments without using the value (real code edition)

[skliper]

cppcheck messages:
{{{
src/os/vxworks6/osnetwork.c:73: performance: Variable 'retval' is reassigned a value before the old one has been used.
src/os/vxworks6/ostimer.c:331: style: Variable 'status' is assigned a value that is never used.
}}}

Recommended fix methods, PICK ONE:

1. Actually check the status variables to see if an error was returned
2. put a (void) cast on the function call instead of storing the data that is not actually ever going to be looked at. This advertises to maintainers and to the compiler and to static analysis that we are purposefully ignoring the return value of the function.

It would be a good idea to check the posix and rtems implementations to see if they have the same construct in this place.

See ticket #157 for the same problem occurring very frequently in unit test code.

[skliper]

Imported from trac issue 135. Created by glimes on 2015-12-10T14:52:04, last modified: 2016-01-14T11:33:37

[skliper]

Trac comment by glimes on 2015-12-31 13:05:51:

osnetwork:
retval is initialized to ERROR,
then is the target of an assignment.
There are no conditionals that might
cause the assignment to be skipped.
Proposed: toss the redundant initializer.

ostimer:
return value of timer_delete is captured in status
then ignored as we are already in an error path.
Proposed: since we are not checking the return value,
change status = timer_delete(...) to (void) timer_delete(...)

[skliper]

Trac comment by glimes on 2015-12-31 13:08:04:

... not sure why I added a "recommend accept" comment to a
ticket that I've not yet marked as work complete, much less
to a ticket where I'm the one preparing the edit ... must have
been a "wrong browser tab" error. Sorry ...

[skliper]

Trac comment by glimes on 2016-01-05 09:56:37:

Commit [changeset:ccd776c] trac-135-repeated-assignments-real-code is ready for merge.

[skliper]

Trac comment by sduran on 2016-01-08 14:34:39:

recommend accept

[skliper]

Trac comment by sstrege on 2016-01-10 18:28:19:

Recommend/accept

[skliper]

Trac comment by jphickey on 2016-01-11 13:11:40:

recommend accept

[skliper]

Trac comment by glimes on 2016-01-11 13:11:43:

Per discussion on CFS CCB telecon,
marking the proposed tickets with
the "osal-4.2" Milestone.

[skliper]

Trac comment by glimes on 2016-01-14 11:31:23:

Included in the 2016-01-11 CCB merge.

[skliper]

Trac comment by glimes on 2016-01-14 11:33:37:

Development advanced to include the 2016-01-11 merge.