Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Phase 2 state machines with F Prime #508

Closed
bocchino opened this issue Aug 27, 2024 · 1 comment
Closed

Integrate Phase 2 state machines with F Prime #508

bocchino opened this issue Aug 27, 2024 · 1 comment
Assignees
Labels
f prime integration Issues related to integration with F Prime
Milestone

Comments

@bocchino
Copy link
Collaborator

Create an alpha release of FPP and make a PR to nasa/fprime.

@bocchino bocchino added the f prime integration Issues related to integration with F Prime label Aug 27, 2024
@bocchino bocchino changed the title Integrate FPP state machines with F Prime Integrate Phase 2 state machines with F Prime Aug 27, 2024
@bocchino bocchino self-assigned this Oct 30, 2024
@bocchino
Copy link
Collaborator Author

bocchino commented Nov 20, 2024

Notes from Review on 11/20/24

Comment Status
General.md vs README.md The structure of the F Prime documentation has changed. This issue is tracked in #548.
Add UML diagram to represent base class/component relationship Done
Style guide note: Avoid using underscore in object names, to avoid name collisions with the code generator Should be added to the F Prime style guide. Out of scope for this issue.
Fix the hard-to-read names of the form m(italic) some token (greyed, no formatting) Done
Document the rules for initial states: (1) Cannot perform port calls; (2) Cannot emit events nor telemetry. If you need an initial port call, have the initial state transition to a START state on the first RTI call received. Added a section to the design doc discussing state machine initialization, including these limitations
Submit coverage reports for UTs Will submit along with PR to nasa/fprime

@bocchino bocchino added this to the v2.3.0 milestone Dec 6, 2024
@bocchino bocchino closed this as completed Jan 7, 2025
@github-project-automation github-project-automation bot moved this from In progress to Done in FPP State Machines Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f prime integration Issues related to integration with F Prime
Projects
Development

No branches or pull requests

1 participant