Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply official python naming conventions #187

Closed
paulober opened this issue Jul 27, 2021 · 0 comments · Fixed by #191
Closed

Apply official python naming conventions #187

paulober opened this issue Jul 27, 2021 · 0 comments · Fixed by #191
Labels
enhancement New feature or request
Milestone

Comments

@paulober
Copy link
Contributor

Describe the bug
Many local variables have names like MyVariable or sth like that, but the naming conventions of python say: my_variable
Most of the functions and methods also are not named like this: def my_function_is_great()

To Reproduce

  1. for example GenericTelemetry.py line 59
  2. a method example: GenericTelemetry.py line 53

Expected behavior
A clear and concise description of what you expected to happen.

Code snips

  1. def displayTelemetryItem(self, datagram, tlmIndex, labelField, valueField):
  2. TlmField1 = tlmItemFormat[tlmIndex]

Additional context
https://www.python.org/dev/peps/pep-0008/

@paulober paulober changed the title Python naming conventions do not exist in this project Apply official python naming conventions Jul 28, 2021
@astrogeco astrogeco added this to the cFS-Draco milestone Aug 21, 2021
@skliper skliper added the enhancement New feature or request label Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants