Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipename refactor removed it from the send pipe info file dump #995

Closed
skliper opened this issue Nov 3, 2020 · 2 comments · Fixed by #1102
Closed

Pipename refactor removed it from the send pipe info file dump #995

skliper opened this issue Nov 3, 2020 · 2 comments · Fixed by #1102

Comments

@skliper
Copy link
Contributor

skliper commented Nov 3, 2020

Describe the bug
#404 removed pipename from the structure that is written when the send pipe info command is sent. Need to add this information back in. Also related to #982. Likely need to reconsider what is output (memory addresses likely not helpful).

To Reproduce
Observe file output from a CFE_SB_SEND_PIPE_INFO_CC command before and after #404 merge.

Expected behavior
#404 shouldn't have changed output file.

Code snips

for(i=0;i<CFE_PLATFORM_SB_MAX_PIPES;i++){
if(CFE_SB.PipeTbl[i].InUse==CFE_SB_IN_USE){
Status = OS_write (fd, &(CFE_SB.PipeTbl[i]), sizeof(CFE_SB_PipeD_t));
if(Status != sizeof(CFE_SB_PipeD_t)){
CFE_SB_FileWriteByteCntErr(Filename,sizeof(CFE_SB_PipeD_t),Status);
OS_close(fd);
return CFE_SB_FILE_IO_ERR;
}/* end if */
FileSize += Status;
EntryCount ++;
}/* end if */

System observed on:
All.

Additional context
Observed in build verification test of 6.8

Reporter Info
Jacob Hageman - NASA/GSFC

Ping @wmoleski

@skliper skliper added this to the 6.8.0 milestone Nov 3, 2020
@astrogeco astrogeco added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Nov 18, 2020
@skliper
Copy link
Contributor Author

skliper commented Nov 18, 2020

@astrogeco this also impacts cert, so it's on my list. Trying to address issues that have more extensive external impacts as a higher priority though.

@skliper skliper removed the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jan 4, 2021
@skliper
Copy link
Contributor Author

skliper commented Jun 10, 2021

Closing backport issue for now due to lack of stakeholder interest. Could always reopen if someone wants to take the time to patch up Bootes.

@skliper skliper closed this as completed Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants