Unsafe macro in cfe_version.h

[skliper]

Is your feature request related to a problem? Please describe.
Unsafe macro (violates coding standard)

cFE/fsw/cfe-core/src/inc/cfe_version.h

Line 48 in 06c0826

#define CFE_STR_HELPER(x) #x /*!< @brief Helper function to concatenate strings from integer macros */

Describe the solution you'd like
Add parentheses

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC

[skliper]

Nevermind. Read up on it, since it quotes it's safe.

[astrogeco]

Nevermind. Read up on it, since it quotes it's safe.

Can you add the stuff you read so we can reference it if it comes up again? I was actually discussing this earlier and wondering if we need to have the integer macros at all. If they're all strings then we wouldn't need the helper functions.

[skliper]

My preference is to remove any unused macros! I just brushed up on the preprocessor macro at https://www.cprogramming.com/reference/preprocessor/stringizing-operator.html, and wrote a quick test program to try and break it and I couldn't (just to confirm it behaved as expected on random strings).