Table Services Task Pipe Function Incorrectly Handling Commands

[skliper]

When calling the appropriate command message handler, the Table Services TaskPipe function is failing to pass the entire message to the command processing function, resulting in a truncated message.

[skliper]

Imported from trac issue 216. Created by sstrege on 2017-10-26T13:16:18, last modified: 2019-03-05T14:58:28

[skliper]

Trac comment by jphickey on 2017-10-27 09:26:07:

I believe this is like 271:

{{{
/* All checks have passed, call the appropriate message handler */
CmdStatus = (CFE_TBL_CmdHandlerTbl[CmdIndx].MsgProcFuncPtr)(&MessagePtr->Byte[CFE_SB_CMD_HDR_SIZE]);
}}}

Should be just simply:

{{{
CmdStatus = (CFE_TBL_CmdHandlerTbl[CmdIndx].MsgProcFuncPtr)(MessagePtr);
}}}

Because this function takes a void* it was never flagged as a type mismatch. TBL services is the only subsystem that works this way.

[skliper]

Trac comment by jphickey on 2017-10-27 09:29:38:

Since it is just a one liner I went ahead and pushed a commit with that change.

Commit [changeset:25d7de3] branch trac-216-tbl-services-fix

[skliper]

Trac comment by sstrege on 2017-10-27 09:33:37:

Funny, I had pushed the same fix yesterday, but my comment was never posted.

Duplicate commit: [changeset:3c9aa94]

[skliper]

Trac comment by sstrege on 2017-10-27 09:34:04:

Recommend/approve either commit

[skliper]

Trac comment by cdknight on 2017-10-27 10:44:48:

recommend approve

[skliper]

Trac comment by glimes on 2017-10-27 12:36:15:

recommend accept (the answer to my concern was "yes")

[skliper]

Trac comment by jphickey on 2017-10-27 12:39:09:

Correct. The intent is that the complete message should be passed through, including header(s), not just the payload.

[skliper]

Trac comment by jhageman on 2019-03-05 14:58:28:

Milestone renamed