Fix #2150, Adds a cast to the negation of unsigned expression #2437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chillfig
added
enhancement
CCB:Ready
chillfig
added
CCB:Approved
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Sep 13, 2023
*Combines:* cFE v7.0.0-rc4+dev384 osal v6.0.0-rc4+dev229 **Includes:** *cFE* - nasa/cFE#2437 *osal* - nasa/osal#1407 - nasa/osal#1408 Co-authored by: Justin Figueroa <chillfig@users.noreply.github.com> Co-authored by: Jacob Hageman <skliper@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Sep 13, 2023
*Combines:* cFE v7.0.0-rc4+dev384 osal v6.0.0-rc4+dev229 **Includes:** *cFE* - nasa/cFE#2437 *osal* - nasa/osal#1407 - nasa/osal#1408 Co-authored by: Justin Figueroa <chillfig@users.noreply.github.com> Co-authored by: Jacob Hageman <skliper@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
int32before negating it, we ensure that the negation operation is being applied to a signed integer, and the result will be as expected.Testing performed
-coverage
-functional test
Expected behavior changes
Supress CodeQL warning
System(s) tested on
Additional context
Concur with the issue that this pr addresses. The problem is that when you apply a negation operator (
-) to an unsigned integer, the result will not be a negative number as maybe expected. Instead, due to two's complement arithmetic, we get a very large positive number. Then, it will cause unexpected results when that large number is assigned to a signed variable like int32.Third party code
N/A
Contributor Info - All information REQUIRED for consideration of pull request
Justin Figueroa, Vantage Systems