Fix #1449, Factor out common code for bitmask check #2248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * See description in header file for argument/return detail | ||
| * | ||
| *-----------------------------------------------------------------*/ | ||
| CFE_Status_t CFE_EVS_CheckBitmaskInRange(const CFE_EVS_BitMaskCmd_Payload_t *CmdPtr, uint16 CommandCode) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
thnkslprpt
force-pushed
the
fix-1449-factor-out-bitmask-check
branch
from
d7cace1
to
5899c8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
Could also add another (almost identical) helper to factor out the bitmask check from
CFE_EVS_EnableAppEventTypeCmd()andCFE_EVS_DisableAppEventTypeCmd(). They weren't included here as they use a different structure to hold the bitmask (they useCFE_EVS_AppNameBitMaskCmd_Payload_t)Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.
Expected behavior changes
No change to behavior or return values.
Contributor Info
Avi Weiss @thnkslprpt