Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify/standardize method for writing files, multiple patterns currently implemented #1597

Open
skliper opened this issue Jun 2, 2021 · 0 comments

Comments

@skliper
Copy link
Contributor

skliper commented Jun 2, 2021

Is your feature request related to a problem? Please describe.
Some files are still written directly from the command handler (main task), see CFE_ES_WriteSysLogCmd for example. Some request the write from a background task using CFE_FS_RunBackgroundFileDump and CFE_FS_Background* routines, see CFE_ES_WriteERLogCmd. Then there's also the unique CFE_ES_RunPerfLogDump with it's own run function that doesn't utilize CFE_FS_RunBackgroundFileDump.

Side note - CFE_ES_SysLogDump does not check for CFE_FS_WriteHeader valid size (just >= 0)

Describe the solution you'd like
Scrub all file writes and implement a single pattern. This should standardize events, error handling, scheduling work, dump deconfliction, etc. Note there's multiple issues with overloaded EIDs in reporting errors, etc. Avoid additional complexity from "backwards compatible" event messages, etc.

Describe alternatives you've considered
If these really require different handling, summarize file write handling and document. Current design is challenging to analyze for file write timing impacts without in-depth knowledge of implementation.

Additional context
#1588 documents some of the EventID issues

Requester Info
Jacob Hageman - NASA/GSFC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant