Fix #4, Consolidate common patterns in sc_app.c #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| for (i = 0; i < SC_NUMBER_OF_ATS; i++) | ||
| } /* end SC_RegisterDumpOnlyTables() */ | ||
|
|
||
| int32 SC_RegisterLoadableTables(void) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion
|
|
||
| } /* end SC_RegisterAllTables() */ | ||
|
|
||
| int32 SC_RegisterDumpOnlyTables(void) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion
skliper
approved these changes
Sep 8, 2022
havencarlson
force-pushed
the
fix#4
branch
2 times, most recently
from
3e1d59c
to
f9b3162
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Fix #4, use loops to consolidate common code patterns in sc_app.c
Testing performed
Unit testing
Expected behavior changes
no impact to behavior
System(s) tested on
Contributor Info - All information REQUIRED for consideration of pull request
Haven Carlson - NASA