Fix #50, Apply consistent Event ID names to common events #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chillfig
requested changes
Nov 1, 2022
fsw/src/hs_events.h
Outdated
| @@ -320,7 +320,7 @@ | |||
| * This event message is issued when a reset counters command has | |||
| * been received. | |||
| */ | |||
| #define HS_RESET_DBG_EID 24 | |||
| #define HS_RESET_INF_EID 24 | |||
There was a problem hiding this comment.
Why does the event name change from DBG to INF? Shouldn't line 316 also change to indicate Informational type?
This line may also need an update if the change is warranted.
https://github.com/thnkslprpt/HS/blob/e90051e221c462b8cf0409253a677e0df8459947/fsw/src/hs_msgdefs.h#L113
There was a problem hiding this comment.
Yeah it's really a matter of interpretation whether to list some of these as DBG or INF.
I will update the comments to align with the common Event ID type as per the updates.
There was a problem hiding this comment.
Should be updated now mate.
thnkslprpt
force-pushed
the
fix-50-apply-consistent-event-id-names
branch
from
e90051e
to
e8bb8ac
Compare
thnkslprpt
force-pushed
the
fix-50-apply-consistent-event-id-names
branch
from
e8bb8ac
to
3d39202
Compare
chillfig
approved these changes
Nov 1, 2022
fsw/src/hs_msgdefs.h
Outdated
| @@ -110,7 +110,7 @@ | |||
| * Successful execution of this command may be verified with | |||
| * the following telemetry: | |||
| * - #HS_HkPacket_t.CmdCount will be cleared | |||
| * - The #HS_RESET_DBG_EID debug event message will be | |||
| * - The #HS_RESET_INF_EID debug event message will be | |||
There was a problem hiding this comment.
Suggested change
| * - The #HS_RESET_INF_EID debug event message will be | |
| * - The #HS_RESET_INF_EID informational event message will be |
thnkslprpt
force-pushed
the
fix-50-apply-consistent-event-id-names
branch
from
3d39202
to
0652ca2
Compare
thnkslprpt
force-pushed
the
fix-50-apply-consistent-event-id-names
branch
from
0652ca2
to
051741b
Compare
chillfig
approved these changes
Apr 6, 2023
thnkslprpt
force-pushed
the
fix-50-apply-consistent-event-id-names
branch
2 times, most recently
from
0a7a50d
to
05a5cf1
Compare
thnkslprpt
force-pushed
the
fix-50-apply-consistent-event-id-names
branch
from
05a5cf1
to
98da814
Compare
thnkslprpt
force-pushed
the
fix-50-apply-consistent-event-id-names
branch
from
98da814
to
5fb454f
Compare
thnkslprpt
force-pushed
the
fix-50-apply-consistent-event-id-names
branch
from
5fb454f
to
36b5b19
Compare
dzbaker
approved these changes
Jul 5, 2024
This was referenced Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
Testing performed
Only GitHub CI actions.
Expected behavior changes
No impact on code behavior (no logic changes).
Consistent Event ID names for the events which are common to all/most cFS components and apps will improve consistency and ease make code review/debugging easier.
Contributor Info
Avi Weiss @thnkslprpt