Fix #106, Consolidate HK variables that are duplicated in the global struct #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thnkslprpt
force-pushed
the
fix-106-consolidate-common-members-of-hk-and-global-structs
branch
from
85a64a7
to
03da887
Compare
thnkslprpt
force-pushed
the
fix-106-consolidate-common-members-of-hk-and-global-structs
branch
from
03da887
to
c05eee0
Compare
jphickey
reviewed
Sep 29, 2023
There was a problem hiding this comment.
Reviewed, but I'm not sure we want to do this. In general we are trying to get away from using telemetry data as real-time state info. Its because the former needs to be formatted in a certain way for sending across the network where the latter should be in a format where it is optimized for real-time access. So while the logical data might overlap, it is generally a good idea to separate this.
thnkslprpt
deleted the
fix-106-consolidate-common-members-of-hk-and-global-structs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).
Expected behavior changes
No change to behavior other than storage location of the variables as outlined above.
Simpler pattern, reduces duplication and eases future maintenance.
Contributor Info
Avi Weiss @thnkslprpt