Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #25, Remove misleading/unnecessary event text #66

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Nov 10, 2022

Checklist

Describe the contribution
Fixes #25
Unnecessary/misleading test ("desc text = OK") has been removed from event messages in DS_TableVerifyFilter() and DS_TableVerifyDestFile().

Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully - except coverage rates which is being addressed in separate issue #65

Expected behavior changes
No impact on logic. "desc text = OK" will no longer be printed in these 2 event messages.

Contributor Info
Avi Weiss @thnkslprpt

@skliper
Copy link
Contributor

skliper commented Nov 10, 2022

@dzbaker @dmknutsen - this change is fine, but what happened to coverage? Did something sneak by?

@dzbaker
Copy link
Contributor

dzbaker commented Nov 14, 2022

@dzbaker @dmknutsen - this change is fine, but what happened to coverage? Did something sneak by?

@skliper Thanks for catching that! We found where we lost the coverage and are working on tests to get back to full coverage.

@thnkslprpt thnkslprpt force-pushed the fix-25-remove-misleading-unnecessary-event-text branch from 05fef4b to f2b4461 Compare November 17, 2022 22:27
@dzbaker dzbaker added this to the Fornax milestone Nov 21, 2022
@dzbaker dzbaker modified the milestones: Fornax, Equuleus Dec 1, 2022
@chillfig chillfig self-requested a review March 9, 2023 19:43
Copy link
Contributor

@chillfig chillfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dzbaker dzbaker merged commit 5f74cd3 into nasa:main Mar 9, 2023
@thnkslprpt thnkslprpt deleted the fix-25-remove-misleading-unnecessary-event-text branch March 9, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reports "desc test = OK" in DS_FLT_TBL_EID even though no validation is being performed
5 participants