-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #6, remove implicit padding #24
Conversation
@dmknutsen can you update the commit message to match the contributing standard? |
CCB:2022-04-27 APPROVED
|
I also suggest improving the commit message to provide a little more context. At minimum maybe something like Note if you are going with the ES definitions, I recommend considering resolving/addressing nasa/cFE#2093. At minimum make it easier to config for 64, but even better if the default would always provide valid address information. |
Fixed format and commit messages in my fork, I can force push those into this PR. See https://github.com/astrogeco/CS/tree/pr24 |
@astrogeco Could you add in the short description that it's specifically the table structures? |
Correct structure definitions to minimize implicit padding added when running on 64-bit systems. Update default tables provided to remove positional dependency on table elements.
Just force-pushed to @dmknutsen fork |
Fix nasa#24, Resolve strict cppcheck style warnings
Describe the contribution
Fix #6
Updated cs_tbledefs.h to correct for implicit padding that gets added when running on a 64-bit system.
Also updated default tables provided (cs_apptbl.c, cs_eepromtbl.c, cs_memorytbl.c, and cs_tablestbl.c) to remove positional dependency on table elements.
Testing performed
Steps taken to test the contribution:
System(s) tested on
Oracle VM VirtualBox
OS: ubuntu-20.10
Versions: cFS Versions: cfe v7.0.0-rc4+dev96, osal v6.0.0-rc4+dev66, psp v1.6.0-rc1+dev14.
Contributor Info - All information REQUIRED for consideration of pull request
Dan Knutsen
NASA Goddard