Fix #311, Use fixed size types in tlm EOT packet #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
added
the
CCB:Ready
skliper
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| CF_Direction_t direction; /**< \brief direction of this transaction */ | ||
| CF_TxnState_t state; /**< \brief Transaction state */ | ||
| CF_CFDP_ConditionCode_t cc; /**< \brief final condition code of operation */ | ||
| uint32 direction; /**< \brief direction of this transaction */ |
Check notice
Code scanning / CodeQL-coding-standard
Use of basic integral type
| CF_TxnState_t state; /**< \brief Transaction state */ | ||
| CF_CFDP_ConditionCode_t cc; /**< \brief final condition code of operation */ | ||
| uint32 direction; /**< \brief direction of this transaction */ | ||
| uint32 state; /**< \brief Transaction state */ |
Check notice
Code scanning / CodeQL-coding-standard
Use of basic integral type
| CF_CFDP_ConditionCode_t cc; /**< \brief final condition code of operation */ | ||
| uint32 direction; /**< \brief direction of this transaction */ | ||
| uint32 state; /**< \brief Transaction state */ | ||
| uint32 cc; /**< \brief final condition code of operation */ |
Check notice
Code scanning / CodeQL-coding-standard
Use of basic integral type
skliper
force-pushed
the
fix311-enum_in_tlm
branch
from
76a8583
to
b6a8e9f
Compare
dzbaker
added
CCB:Approved
and removed
CCB:Ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Testing performed
CI
Expected behavior changes
Fixed size types in tlm
System(s) tested on
CI
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC (via stakeholder request)