Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Investigate failing cuDF timezone tests #1187

Closed
LiamConnors opened this issue Oct 15, 2024 · 2 comments · Fixed by #1196
Closed

[Bug]: Investigate failing cuDF timezone tests #1187

LiamConnors opened this issue Oct 15, 2024 · 2 comments · Fixed by #1196

Comments

@LiamConnors
Copy link
Member

Describe the bug

There are currently a few tests failing for timezones and cuDF:


tests/utils.py:60: AssertionError
=========================== short test summary info ============================
FAILED tests/expr_and_series/convert_time_zone_test.py::test_convert_time_zone_from_none[cudf_constructor] - AssertionError: ('2020-01-01T05:45+0000', '2020-01-01T05:45+0545')
FAILED tests/expr_and_series/convert_time_zone_test.py::test_convert_time_zone[cudf_constructor] - AssertionError: ('2020-01-01T05:45+0000', '2020-01-01T05:45+0545')
FAILED tests/expr_and_series/convert_time_zone_test.py::test_convert_time_zone_series[cudf_constructor] - AssertionError: ('2020-01-01T05:45+0000', '2020-01-01T05:45+0545')
FAILED tests/expr_and_series/replace_time_zone_test.py::test_replace_time_zone_series[cudf_constructor] - AssertionError: ('2020-01-01T00:00+0000', '2020-01-01T00:00+0545')
FAILED tests/expr_and_series/replace_time_zone_test.py::test_replace_time_zone[cudf_constructor] - AssertionError: ('2020-01-01T00:00+0000', '2020-01-01T00:00+0545')
===== 5 failed, 4842 passed, 15 skipped, 143 xfailed in 108.35s (0:01:48) ======

Steps or code to reproduce the bug

Run the cuDF testing notebook;
https://www.kaggle.com/code/marcogorelli/testing-cudf-in-narwhals

Expected results

No error

Actual results

Errors on five tests

Please run narwhals.show_version() and enter the output below.

Version on main

Relevant log output

No response

@MarcoGorelli
Copy link
Member

thanks @LiamConnors !

there's been a new cudf release, so I've updated the top cell of the notebook to get the latest version https://www.kaggle.com/code/marcogorelli/testing-cudf-in-narwhals?scriptVersionId=201439002

there's a couple of [XPASS(strict)] which is always nice to see 🥳

this particular bug has been fixed by the looks of it, it's just not available in the latest cuDF release (yet?) rapidsai/cudf#16973

@LiamConnors
Copy link
Member Author

Thanks @MarcoGorelli! Ah, I see. I hadn't noticed it was related to the issue you already raised. I'll update the tests to pass for the current version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants