Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: napalm-automation-community/napalm-mos
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4.0.2
Choose a base ref
...
head repository: napalm-automation-community/napalm-mos
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5.0.0
Choose a head ref
  • 4 commits
  • 4 files changed
  • 1 contributor

Commits on Jul 2, 2024

  1. bump major version to 5.0.0

    bewing committed Jul 2, 2024
    Copy the full SHA
    f8b2bbe View commit details
  2. update gh action versions

    bewing committed Jul 2, 2024
    Copy the full SHA
    02e6cc1 View commit details
  3. update pypi action vars

    bewing committed Jul 2, 2024
    Copy the full SHA
    3fd6b49 View commit details
  4. Merge pull request #35 from napalm-automation-community/develop

    Release 5.0.0
    bewing authored Jul 2, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    c2a8fe8 View commit details
Showing with 14 additions and 15 deletions.
  1. +9 −9 .github/workflows/commit.yaml
  2. +2 −2 napalm_mos/mos.py
  3. +1 −2 requirements.txt
  4. +2 −2 setup.py
18 changes: 9 additions & 9 deletions .github/workflows/commit.yaml
Original file line number Diff line number Diff line change
@@ -8,12 +8,12 @@ jobs:
strategy:
max-parallel: 4
matrix:
python-version: ["3.7", "3.8", "3.9", "3.10"]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
steps:
- name: Checkout repository
uses: actions/checkout@v2
uses: actions/checkout@v4
- name: Setup Python
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
@@ -33,9 +33,9 @@ jobs:
needs: test
steps:
- name: Checkout repository
uses: actions/checkout@v2
uses: actions/checkout@v4
- name: Setup Python
uses: actions/setup-python@v1
uses: actions/setup-python@v5
with:
python-version: 3.9
- name: Install dependencies
@@ -47,13 +47,13 @@ jobs:
python setup.py bdist_wheel --build-number $GITHUB_RUN_NUMBER
- name: Upload to test
if: github.event_name == 'push'
uses: pypa/gh-action-pypi-publish@master
uses: pypa/gh-action-pypi-publish@release/v1
with:
password: ${{ secrets.TEST_PYPI_API_TOKEN }}
repository_url: https://test.pypi.org/legacy/
skip_existing: true
repository-url: https://test.pypi.org/legacy/
skip-existing: true
- name: Upload Pypi
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags')
uses: pypa/gh-action-pypi-publish@master
uses: pypa/gh-action-pypi-publish@release/v1
with:
password: ${{ secrets.PYPI_API_TOKEN }}
4 changes: 2 additions & 2 deletions napalm_mos/mos.py
Original file line number Diff line number Diff line change
@@ -795,7 +795,7 @@ def get_optics(self):
optics_detail[port] = port_detail
return optics_detail

def get_config(self, retrieve="all", full=False, sanitized=False):
def get_config(self, retrieve="all", full=False, sanitized=False, format="text"):
"""get_config implementation for MOS."""

get_startup = False
@@ -812,7 +812,7 @@ def get_config(self, retrieve="all", full=False, sanitized=False):
if not get_startup and not get_running:
Exception("Wrong retrieve filter: {}".format(retrieve))

output = self.device.run_commands(commands, encoding="text")
output = self.device.run_commands(commands, encoding=format)

if sanitized:
output = [
3 changes: 1 addition & 2 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
napalm>=4.0.0
pyeapi>=0.8.1
napalm>=5.0.0
4 changes: 2 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@

setup(
name="napalm-mos",
version="4.0.2",
version="5.0.0",
packages=find_packages(),
author="Benny Holmgren, Brandon Ewing",
author_email="benny@holmgren.id.au, brandon.ewing@warningg.com",
@@ -23,5 +23,5 @@
url="https://github.com/napalm-automation-community/napalm-mos",
include_package_data=True,
install_requires=reqs,
python_requires=">=3.7",
python_requires=">=3.8",
)