Using scale_colour_xxx throws a warning with recent ggplot2

[DanChaltiel]

Hi,

Thank you for this wonderful package.

Using scale_colour_xxx() throws a warning with recent ggplot2:

Warning message:
The `scale_name` argument of `discrete_scale()` is deprecated as of ggplot2 3.5.0.

It seems to pertain to this line :

ggsci/R/discrete-lancet.R

Line 88 in 0b9645a

discrete_scale("fill", "lancet", pal_lancet(palette, alpha), ...)

From what I understood from tidyverse/ggplot2#1312, the deprecation means that the name should be simply removed: discrete_scale("fill", palette=pal_lancet(palette, alpha), ...).

[nanxstats]

Thanks! Fixed in #26.

[nanxstats]

ggsci 3.0.2 is now on CRAN: https://cran.r-project.org/package=ggsci

[flyingicedragon]

ggsci 3.0.2 is now on CRAN: https://cran.r-project.org/package=ggsci

Please use ggplot2 (>= 3.5.0) in DESCRIPTION as ggsci can't work with older version of ggplot after this change.

[nanxstats]

Please use ggplot2 (>= 3.5.0) in DESCRIPTION as ggsci can't work with older version of ggplot after this change.

Thanks for spotting this issue. I'm on it: #29