Add keys to improve handling of Axolotl in Phosh #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StartupNotify enables showing the icon fullscreen for a short period of time after starting Axolotl. UsesNotifications puts Axolotl in the GNOME notifications app list.
|
Nice, looks good to me. We have a few other duplicated .desktop files in the repo - id say lets keep them all in sync. $ find . -type f -name "*.desktop" -not -path "*flatpak-builder*"
./flatpak/web/org.nanuc.Axolotl.desktop
./flatpak/qt/org.nanuc.Axolotl.desktop
./scripts/axolotl.desktop
./snap/gui/axolotl.desktop
./click/textsecure.desktop
./appimage/AppDir/axolotl.desktop
./deb/axolotl.desktop |
|
Thanks for your review! I think these four files ./scripts/axolotl.desktop are used in non-Phosh systems and to my knowlegde the changes will have no impact. But the flatpak-qt file should be changed, too. I will add that to the PR. |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
olof-nord
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StartupNotify enables showing the icon fullscreen for a short period of time after starting Axolotl.
UsesNotifications puts Axolotl in the GNOME notifications app list.