Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Callback response misleading #2192

Closed
arranHarty123 opened this issue Aug 3, 2019 · 2 comments · Fixed by #2193
Closed

Callback response misleading #2192

arranHarty123 opened this issue Aug 3, 2019 · 2 comments · Fixed by #2193
Assignees
@cryptocode
Labels
enhancement
Milestone
V20.0

Comments

@arranHarty123
Copy link

[2019-Aug-03 13:49:04.666131]: Callback to address:port failed with status: Created

Potentially as 201 returned
@cryptocode cryptocode self-assigned this Aug 3, 2019
@cryptocode
Copy link
Contributor

cryptocode commented Aug 3, 2019 •
edited
Loading

Thanks for the report. To give more context from Discord: this is a mongodb microservice endpoint returning 201, probably along with a Location header entry for the document id. 201 should not be logged as an error (in fact, no 2xx code should)

@cryptocode cryptocode added this to the V20.0 milestone Aug 3, 2019
@cryptocode cryptocode mentioned this issue Aug 3, 2019
Merged
@arranHarty123
Copy link
Author

Yep. Looks like its 201 for created (see https://restheart.org/try.html)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cryptocode cryptocode

Labels
enhancement
Projects
None yet
Milestone
V20.0
Development

Successfully merging a pull request may close this issue.

In http callback, don't log any http responses indicating success as errors cryptocode/raiblocks
2 participants
@cryptocode @arranHarty123