diff --git a/nano/core_test/node.cpp b/nano/core_test/node.cpp index 68083adfee..b41fe3403d 100644 --- a/nano/core_test/node.cpp +++ b/nano/core_test/node.cpp @@ -3193,6 +3193,7 @@ TEST (node, block_processor_signatures) /* * State blocks go through a different signature path, ensure invalidly signed state blocks are rejected + * This test can freeze if the wake conditions in block_processor::flush are off, for that reason this is done async here */ TEST (node, block_processor_reject_state) { @@ -3204,12 +3205,14 @@ TEST (node, block_processor_reject_state) send1->signature.bytes[0] ^= 1; ASSERT_FALSE (node.ledger.block_exists (send1->hash ())); node.process_active (send1); - node.block_processor.flush (); + auto flushed = std::async (std::launch::async, [&node] { node.block_processor.flush (); }); + ASSERT_NE (std::future_status::timeout, flushed.wait_for (5s)); ASSERT_FALSE (node.ledger.block_exists (send1->hash ())); auto send2 (std::make_shared (nano::test_genesis_key.pub, genesis.hash (), nano::test_genesis_key.pub, nano::genesis_amount - 2 * nano::Gxrb_ratio, nano::test_genesis_key.pub, nano::test_genesis_key.prv, nano::test_genesis_key.pub, 0)); node.work_generate_blocking (*send2); node.process_active (send2); - node.block_processor.flush (); + auto flushed2 = std::async (std::launch::async, [&node] { node.block_processor.flush (); }); + ASSERT_NE (std::future_status::timeout, flushed2.wait_for (5s)); ASSERT_TRUE (node.ledger.block_exists (send2->hash ())); } diff --git a/nano/node/blockprocessor.cpp b/nano/node/blockprocessor.cpp index b01d3a3795..ccc7d0dada 100644 --- a/nano/node/blockprocessor.cpp +++ b/nano/node/blockprocessor.cpp @@ -21,6 +21,16 @@ state_block_signature_verification (node.checker, node.ledger.network_params.led state_block_signature_verification.blocks_verified_callback = [this](std::deque & items, std::vector const & verifications, std::vector const & hashes, std::vector const & blocks_signatures) { this->process_verified_state_blocks (items, verifications, hashes, blocks_signatures); }; + state_block_signature_verification.transition_inactive_callback = [this]() { + if (this->flushing) + { + { + // Prevent a race with condition.wait in block_processor::flush + nano::lock_guard guard (this->mutex); + } + this->condition.notify_all (); + } + }; } nano::block_processor::~block_processor () diff --git a/nano/node/state_block_signature_verification.cpp b/nano/node/state_block_signature_verification.cpp index 5683a0b5ed..9dc6700221 100644 --- a/nano/node/state_block_signature_verification.cpp +++ b/nano/node/state_block_signature_verification.cpp @@ -56,6 +56,9 @@ void nano::state_block_signature_verification::run (uint64_t state_block_signatu lk.lock (); } active = false; + lk.unlock (); + transition_inactive_callback (); + lk.lock (); } else { diff --git a/nano/node/state_block_signature_verification.hpp b/nano/node/state_block_signature_verification.hpp index 7af89bfd8f..993026dade 100644 --- a/nano/node/state_block_signature_verification.hpp +++ b/nano/node/state_block_signature_verification.hpp @@ -25,6 +25,7 @@ class state_block_signature_verification bool is_active (); std::function &, std::vector const &, std::vector const &, std::vector const &)> blocks_verified_callback; + std::function transition_inactive_callback; private: nano::signature_checker & signature_checker;