Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is the python c'tor comment out of date? #688

Closed
2bndy5 opened this issue Nov 20, 2020 · 2 comments
Closed

is the python c'tor comment out of date? #688

2bndy5 opened this issue Nov 20, 2020 · 2 comments
Assignees
Labels

Comments

@2bndy5
Copy link
Member

2bndy5 commented Nov 20, 2020

# RPi Alternate, with SPIDEV - Note: Edit RF24/arch/BBB/spi.cpp and set 'this->device = "/dev/spidev0.0";;' or as listed in /dev

I've been proofreading... I came across this line and couldn't find the file RF24/arch/BBB/spi.cpp. I noticed the C++ linux examples use a more generic comment that references links to documentation for non-RPi SoCs.

/****************** Linux (BBB,x86,etc) ***********************/
// See http://tmrh20.github.io/RF24/pages.html for more information on usage
// See http://iotdk.intel.com/docs/master/mraa/ for more information on MRAA
// See https://www.kernel.org/doc/Documentation/spi/spidev for more information on SPIDEV

I had blindly copied these comments into the new examples, so should I convert the later to a python comment and use it the new python examples?

@2bndy5 2bndy5 self-assigned this Nov 20, 2020
@TMRh20
Copy link
Member

TMRh20 commented Nov 21, 2020

I think RF24/arch/BBB/spi.cpp is the original SPIDEV driver which was for BeagleBoneBlack. It probably still applies, but I don't think we need to mention BBB specifically.

@2bndy5
Copy link
Member Author

2bndy5 commented Nov 21, 2020

ok I'll replace the

# RPi Alternate, with SPIDEV - Note: Edit RF24/arch/BBB/spi.cpp and
# set 'this->device = "/dev/spidev0.0";;' or as listed in /dev 

with

################## Linux (BBB,x86,etc) #########################
# See http://tmrh20.github.io/RF24/pages.html for more information on usage
# See http://iotdk.intel.com/docs/master/mraa/ for more information on MRAA
# See https://www.kernel.org/doc/Documentation/spi/spidev for more information on SPIDEV

in the new python examples (old pyRF24 example will be replaced/removed due to new python examples -- making maintenance easier).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants