From c7ceb60d1c6134d22e58804310017d9eaeddcd38 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Iv=C3=A1n=20Ovejero?= Date: Fri, 16 Jun 2023 10:07:19 +0200 Subject: [PATCH 1/4] ci: Prevent e2e failure on `commented` type review --- .github/workflows/e2e-tests-pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/e2e-tests-pr.yml b/.github/workflows/e2e-tests-pr.yml index 0b92e187bdef9..e9e3132d474be 100644 --- a/.github/workflows/e2e-tests-pr.yml +++ b/.github/workflows/e2e-tests-pr.yml @@ -47,5 +47,5 @@ jobs: run: exit 0 - name: Fail job if run-e2e-tests failed - if: ${{ github.event.review.state != 'approved' || needs.run-e2e-tests.result == 'failure' }} + if: ${{ (github.event.review.state != 'approved' && github.event.review.state != 'commented') || needs.run-e2e-tests.result == 'failure' }} run: exit 1 From 93c293afc91bb5d884b066cb61f0f55d7b007edd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Iv=C3=A1n=20Ovejero?= Date: Fri, 16 Jun 2023 10:10:01 +0200 Subject: [PATCH 2/4] fix: Indentation --- .github/workflows/e2e-tests-pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/e2e-tests-pr.yml b/.github/workflows/e2e-tests-pr.yml index e9e3132d474be..0b92e187bdef9 100644 --- a/.github/workflows/e2e-tests-pr.yml +++ b/.github/workflows/e2e-tests-pr.yml @@ -47,5 +47,5 @@ jobs: run: exit 0 - name: Fail job if run-e2e-tests failed - if: ${{ (github.event.review.state != 'approved' && github.event.review.state != 'commented') || needs.run-e2e-tests.result == 'failure' }} + if: ${{ github.event.review.state != 'approved' || needs.run-e2e-tests.result == 'failure' }} run: exit 1 From 286ba375c1f9b7dc4510e77436d8ba62dac51aec Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Iv=C3=A1n=20Ovejero?= Date: Fri, 16 Jun 2023 10:11:33 +0200 Subject: [PATCH 3/4] fix: Indentation again --- .github/workflows/e2e-tests-pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/e2e-tests-pr.yml b/.github/workflows/e2e-tests-pr.yml index 0b92e187bdef9..f2fd0196cfa51 100644 --- a/.github/workflows/e2e-tests-pr.yml +++ b/.github/workflows/e2e-tests-pr.yml @@ -47,5 +47,5 @@ jobs: run: exit 0 - name: Fail job if run-e2e-tests failed - if: ${{ github.event.review.state != 'approved' || needs.run-e2e-tests.result == 'failure' }} + if: ${{ (github.event.review.state != 'approved' && github.event.review.state != 'commented') || needs.run-e2e-tests.result == 'failure' run: exit 1 From fce0d8df1ee12f8ed94de72204748cefdb8a39ef Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Iv=C3=A1n=20Ovejero?= Date: Fri, 16 Jun 2023 10:13:16 +0200 Subject: [PATCH 4/4] fix: Closing brackets --- .github/workflows/e2e-tests-pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/e2e-tests-pr.yml b/.github/workflows/e2e-tests-pr.yml index f2fd0196cfa51..1d9ead6db8fdc 100644 --- a/.github/workflows/e2e-tests-pr.yml +++ b/.github/workflows/e2e-tests-pr.yml @@ -47,5 +47,5 @@ jobs: run: exit 0 - name: Fail job if run-e2e-tests failed - if: ${{ (github.event.review.state != 'approved' && github.event.review.state != 'commented') || needs.run-e2e-tests.result == 'failure' + if: ${{ (github.event.review.state != 'approved' && github.event.review.state != 'commented') || needs.run-e2e-tests.result == 'failure' }} run: exit 1